Bug 54678 - Web Inspector: get rid of InspectorInstrumentation::inspectorAgents() map
Summary: Web Inspector: get rid of InspectorInstrumentation::inspectorAgents() map
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-17 12:02 PST by Yury Semikhatsky
Modified: 2011-08-09 06:03 PDT (History)
11 users (show)

See Also:

Attachments
Patch (6.23 KB, patch)
2011-02-17 12:05 PST, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Patch (6.64 KB, patch)
2011-02-17 12:21 PST, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Patch (16.65 KB, patch)
2011-08-09 02:54 PDT, Yury Semikhatsky 		pfeldman: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2011-02-17 12:02:14 PST 
The agent can be retrieve from the corresponding InspectorController on the Page and there is no need in additional map. Also there is no page in case of worker threads.
Comment 1 Yury Semikhatsky 2011-02-17 12:05:37 PST 
Created attachment 82841 [details]
Patch
Comment 2 WebKit Review Bot 2011-02-17 12:12:05 PST 
Attachment 82841 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7920835
Comment 3 Yury Semikhatsky 2011-02-17 12:21:09 PST 
Created attachment 82845 [details]
Patch
Comment 4 Pavel Feldman 2011-02-17 22:11:00 PST 
Comment on attachment 82845 [details]
Patch

I don't see why this change is necessary.
Comment 5 Yury Semikhatsky 2011-08-09 02:54:19 PDT 
Created attachment 103340 [details]
Patch
Comment 6 Pavel Feldman 2011-08-09 04:41:52 PDT 
Comment on attachment 103340 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=103340&action=review

> Source/WebCore/inspector/InstrumentingAgents.h:171
> +InstrumentingAgents* instrumentationForWorkerContext(WorkerContext*);

Looks good overall. It is not clear what the call sites are going to look like. Do you have a clue?
Comment 7 Yury Semikhatsky 2011-08-09 06:03:55 PDT 
Committed r92677: <http://trac.webkit.org/changeset/92677>