Bug 54670 – Web Inspector: merge ConsoleView into ConsolePanel.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Podivilov]

Web Inspector: merge ConsoleView into ConsolePanel.

ConsolePanel is ConsoleView shown in a fully opened drawer. We can easily merge this classes together so ConsoleView can reuse Panel functionality.
This is needed to implement snippet editor as sidebar pane in console panel.

[Pavel Podivilov]

Created attachment 82824 [details]
Patch.

- Add ConsoleView functions to ConsolePanel
- ConsoleView class
- Rename ConsoleView.js to ConsoleMessage.js

[Pavel Podivilov]

Created attachment 82825 [details]
Diff between old ConsoleView and new ConsolePanel

[Pavel Feldman]

Comment on attachment 82824 [details]
Patch.

Please provide diff with 
git config
[diff]
        renames = copies

[Pavel Podivilov]

Created attachment 91666 [details]
Patch.

No moves/renames, just make ConsoleView a panel.

[Yury Semikhatsky]

Comment on attachment 91666 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=91666&action=review

> Source/WebCore/ChangeLog:7
> +

Please give a brief description of the changes made. It's not clear in particular how conversion of ConsoleView into a panel helps us to add implement snippet editor.

> Source/WebCore/inspector/front-end/ConsoleView.js:32
> +WebInspector.ConsolePanel = function(drawer)

Containing file should be renamed as well.

> Source/WebCore/inspector/front-end/ConsoleView.js:248
> +        this._previousConsoleState = WebInspector.drawer.state;

This code should be removed from ConsolePanel.js, shouldn't it?

> Source/WebCore/inspector/front-end/inspector.js:192
> +            this.panels.console = this.console;

This method is supposed to create panels.

[Pavel Podivilov]

Created attachment 92238 [details]
Patch.

Console view in drawer looks exactly the same as console panel. Merging ConsoleView and ConsolePanel together
will allow us to reuse panel's functionality (e.g. resizable sidebar) even when console is docked.

[Pavel Podivilov]

(In reply to comment #5)
> (From update of attachment 91666 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=91666&action=review
> 
> > Source/WebCore/ChangeLog:7
> > +
> 
> Please give a brief description of the changes made. It's not clear in particular how conversion of ConsoleView into a panel helps us to add implement snippet editor.

Done.

> 
> > Source/WebCore/inspector/front-end/ConsoleView.js:32
> > +WebInspector.ConsolePanel = function(drawer)
> 
> Containing file should be renamed as well.
> 
> > Source/WebCore/inspector/front-end/ConsoleView.js:248
> > +        this._previousConsoleState = WebInspector.drawer.state;
> 
> This code should be removed from ConsolePanel.js, shouldn't it?

Let me do it in a follow up patch.

> 
> > Source/WebCore/inspector/front-end/inspector.js:192
> > +            this.panels.console = this.console;
> 
> This method is supposed to create panels.

Done.

[Pavel Podivilov]

Committed r86589: <http://trac.webkit.org/changeset/86589>

[Andrew Wilson]

This seems to be breaking the chromium canary bots:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&group=%40ToT%20-%20chromium.org&tests=http%2Ftests%2Finspector%2Fchange-iframe-src.html%2Chttp%2Ftests%2Finspector%2Fconsole-resource-errors.html%2Chttp%2Ftests%2Finspector%2Fresource-tree%2Fresource-tree-frame-add.html

[Andrew Wilson]

Reverted r86589 for reason:

Broke

Committed r86595: <http://trac.webkit.org/changeset/86595>

[Pavel Podivilov]

Committed r86660: <http://trac.webkit.org/changeset/86660>