Bug 54669 - IndexedDB: Populate indexes created for object stores with data
Summary: IndexedDB: Populate indexes created for object stores with data
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Hans Wennborg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-17 09:26 PST by Hans Wennborg
Modified: 2011-02-18 01:56 PST (History)
3 users (show)

See Also:

Attachments
Patch (7.31 KB, patch)
2011-02-17 09:28 PST, Hans Wennborg 		jorlow: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Wennborg 2011-02-17 09:26:57 PST 
IndexedDB: Populate indexes created for object stores with data
Comment 1 Hans Wennborg 2011-02-17 09:28:30 PST 
Created attachment 82821 [details]
Patch
Comment 2 Jeremy Orlow 2011-02-17 09:50:23 PST 
Comment on attachment 82821 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82821&action=review

great stuff!

> Source/WebCore/storage/IDBIndexBackendImpl.h:-32
> -

Isnt  this space typical?

> Source/WebCore/storage/IDBObjectStoreBackendImpl.cpp:328
> +        if (!it->second->hasValidId())

Probably worth a comment
Comment 3 Hans Wennborg 2011-02-18 01:56:50 PST 
Committed r78980: <http://trac.webkit.org/changeset/78980>