RESOLVED FIXED Bug 54660
The run-sunspider --v8-suite doesn't work
https://bugs.webkit.org/show_bug.cgi?id=54660
Summary The run-sunspider --v8-suite doesn't work
Peter Varga
Reported 2011-02-17 07:29:53 PST
The Tools/Scripts/run-sunspider script's help contains the --v8-suite option to use V8 benchmark suite but it doesn't work.
Attachments
proposed patch (1.31 KB, patch)
2011-02-17 07:33 PST, Peter Varga
ossy: review+
ossy: commit-queue-
proposed patch v2 (1.85 KB, patch)
2011-02-17 08:04 PST, Peter Varga
no flags
Peter Varga
Comment 1 2011-02-17 07:33:34 PST
Created attachment 82799 [details] proposed patch
Csaba Osztrogonác
Comment 2 2011-02-17 07:42:06 PST
Comment on attachment 82799 [details] proposed patch Good catch, r=me. The help of this script says "--v8-suite", same as PerformanceTests/sunspider/sunspider script.
Csaba Osztrogonác
Comment 3 2011-02-17 07:43:58 PST
Comment on attachment 82799 [details] proposed patch Good catch, r=me. The help of this script says "--v8-suite", same as PerformanceTests/sunspider/sunspider script.
Peter Varga
Comment 4 2011-02-17 08:04:11 PST
Created attachment 82807 [details] proposed patch v2 Now the run-sunspider script work with --v8 and --v8-suite as well because GETOPT is lazy.
Csaba Osztrogonác
Comment 5 2011-02-17 08:14:26 PST
Comment on attachment 82807 [details] proposed patch v2 Much better than the previous one. ;)
WebKit Commit Bot
Comment 6 2011-02-17 08:35:46 PST
Comment on attachment 82807 [details] proposed patch v2 Clearing flags on attachment: 82807 Committed r78835: <http://trac.webkit.org/changeset/78835>
WebKit Commit Bot
Comment 7 2011-02-17 08:35:51 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.