Bug 54660 - The run-sunspider --v8-suite doesn't work
Summary: The run-sunspider --v8-suite doesn't work
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Peter Varga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-17 07:29 PST by Peter Varga
Modified: 2011-02-17 08:35 PST (History)
3 users (show)

See Also:

Attachments
proposed patch (1.31 KB, patch)
2011-02-17 07:33 PST, Peter Varga 		ossy: review+
ossy: commit-queue-
Details | Formatted Diff | Diff
proposed patch v2 (1.85 KB, patch)
2011-02-17 08:04 PST, Peter Varga 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Varga 2011-02-17 07:29:53 PST 
The Tools/Scripts/run-sunspider script's help contains the --v8-suite option to use V8 benchmark suite but it doesn't work.
Comment 1 Peter Varga 2011-02-17 07:33:34 PST 
Created attachment 82799 [details]
proposed patch
Comment 2 Csaba Osztrogonác 2011-02-17 07:42:06 PST 
Comment on attachment 82799 [details]
proposed patch

Good catch, r=me. 

The help of this script says "--v8-suite", same 
as PerformanceTests/sunspider/sunspider script.
Comment 3 Csaba Osztrogonác 2011-02-17 07:43:58 PST 
Comment on attachment 82799 [details]
proposed patch

Good catch, r=me. 

The help of this script says "--v8-suite", same 
as PerformanceTests/sunspider/sunspider script.
Comment 4 Peter Varga 2011-02-17 08:04:11 PST 
Created attachment 82807 [details]
proposed patch v2

Now the run-sunspider script work with --v8 and --v8-suite as well because GETOPT is lazy.
Comment 5 Csaba Osztrogonác 2011-02-17 08:14:26 PST 
Comment on attachment 82807 [details]
proposed patch v2

Much better than the previous one. ;)
Comment 6 WebKit Commit Bot 2011-02-17 08:35:46 PST 
Comment on attachment 82807 [details]
proposed patch v2

Clearing flags on attachment: 82807

Committed r78835: <http://trac.webkit.org/changeset/78835>
Comment 7 WebKit Commit Bot 2011-02-17 08:35:51 PST 
All reviewed patches have been landed.  Closing bug.