RESOLVED FIXED Bug 54650
check-webkit-style falsely complains about WebKitGTK+ public headers 
https://bugs.webkit.org/show_bug.cgi?id=54650
Summary check-webkit-style falsely complains about WebKitGTK+ public headers
Christian Dywan
Reported 2011-02-17 06:50:47 PST
Source/WebKit/gtk/webkit/webkitwebgroup.h:52: Extra space before ( in function call [whitespace/parens] [4] Source/WebKit/gtk/webkit/webkitwebgroup.h:56: WEBKIT_API should only appear in the chromium public directory. [readability/webkit_api] [5] Source/WebKit/gtk/webkit/webkitwebgroup.h:62: The parameter name "web_group" adds no information, so it should be removed. [readability/parameter_name] [5] These are all false positives.
Attachments
Patch (6.49 KB, patch)
2011-02-18 11:37 PST, David Levin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Levin
Comment 1 2011-02-18 11:37:52 PST
Created attachment 82987 [details] Patch
Eric Seidel (no email)
Comment 2 2011-02-18 12:41:12 PST
Comment on attachment 82987 [details] Patch OK.
WebKit Commit Bot
Comment 3 2011-02-18 21:52:05 PST
Comment on attachment 82987 [details] Patch Clearing flags on attachment: 82987 Committed r79095: <http://trac.webkit.org/changeset/79095>
WebKit Commit Bot
Comment 4 2011-02-18 21:52:09 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.