Bug 54650 - check-webkit-style falsely complains about WebKitGTK+ public headers
Summary: check-webkit-style falsely complains about WebKitGTK+ public headers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Major
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-17 06:50 PST by Christian Dywan
Modified: 2011-02-18 21:52 PST (History)
3 users (show)

See Also:

Attachments
Patch (6.49 KB, patch)
2011-02-18 11:37 PST, David Levin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Dywan 2011-02-17 06:50:47 PST 
Source/WebKit/gtk/webkit/webkitwebgroup.h:52:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebKit/gtk/webkit/webkitwebgroup.h:56:  WEBKIT_API should only appear in the chromium public directory.  [readability/webkit_api] [5]
Source/WebKit/gtk/webkit/webkitwebgroup.h:62:  The parameter name "web_group" adds no information, so it should be removed.  [readability/parameter_name] [5]

These are all false positives.
Comment 1 David Levin 2011-02-18 11:37:52 PST 
Created attachment 82987 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-02-18 12:41:12 PST 
Comment on attachment 82987 [details]
Patch

OK.
Comment 3 WebKit Commit Bot 2011-02-18 21:52:05 PST 
Comment on attachment 82987 [details]
Patch

Clearing flags on attachment: 82987

Committed r79095: <http://trac.webkit.org/changeset/79095>
Comment 4 WebKit Commit Bot 2011-02-18 21:52:09 PST 
All reviewed patches have been landed.  Closing bug.