Bug 54640 - [Chromium] media/video-display-toggle.html fails (IMAGE) on all platforms
Summary: [Chromium] media/video-display-toggle.html fails (IMAGE) on all platforms
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-17 05:10 PST by Mikhail Naganov
Modified: 2011-02-23 00:52 PST (History)
3 users (show)

See Also:


Attachments
Patch (2.29 KB, patch)
2011-02-22 13:03 PST, Anna Cavender
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Anna Cavender 2011-02-22 11:27:41 PST
This test assumes that when the "playing" event fires, the controls will change from the "play" glyph to the "pause" glyph.  This may or may not be the case as the drawing of the controls happens asynchronously.

I propose a change that acts on "canplaythrough" (when the video is loaded and ready) and then seeks to a frame (so that the pixel diff is guaranteed) after toggling the display.

Patch coming shortly.
Comment 2 Anna Cavender 2011-02-22 13:03:40 PST
Created attachment 83372 [details]
Patch
Comment 3 WebKit Commit Bot 2011-02-23 00:27:54 PST
Comment on attachment 83372 [details]
Patch

Clearing flags on attachment: 83372

Committed r79415: <http://trac.webkit.org/changeset/79415>
Comment 4 WebKit Commit Bot 2011-02-23 00:27:59 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Commit Bot 2011-02-23 00:52:12 PST
The commit-queue encountered the following flaky tests while processing attachment 83372 [details]:

http/tests/websocket/tests/multiple-connections.html bug 53825 (author: abarth@webkit.org)
The commit-queue is continuing to process your patch.