Bug 54640 – [Chromium] media/video-display-toggle.html fails (IMAGE) on all platforms

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Mikhail Naganov]

See logs (search for media/video-display-toggle.html):

http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.5/builds/1315/steps/webkit_tests/logs/stdio
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Linux/builds/2468/steps/webkit_tests/logs/stdio
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win/builds/1607/steps/webkit_tests/logs/stdio

This test was already marked as failing, but missed a bugzilla issue.

[Anna Cavender]

This test assumes that when the "playing" event fires, the controls will change from the "play" glyph to the "pause" glyph.  This may or may not be the case as the drawing of the controls happens asynchronously.

I propose a change that acts on "canplaythrough" (when the video is loaded and ready) and then seeks to a frame (so that the pixel diff is guaranteed) after toggling the display.

Patch coming shortly.

[Anna Cavender]

Created attachment 83372 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 83372 [details]
Patch

Clearing flags on attachment: 83372

Committed r79415: <http://trac.webkit.org/changeset/79415>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 83372 [details]:

http/tests/websocket/tests/multiple-connections.html bug 53825 (author: [e-mail])
The commit-queue is continuing to process your patch.