Bug 54628 – [GStreamer] Add 'location' property in webkitwebsrc

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Andoni]

Created attachment 82771 [details]
add 'location' property

Add the 'location' property to the webkitwebsrc so that get_element_make_from_uri() can set the uri on the element.

[Philippe Normand]

Could you post a patch with a ChangeLog please? See also http://www.webkit.org/coding/contributing.html :)

[Andoni]

Created attachment 82776 [details]
Patch

[WebKit Review Bot]

Attachment 82776 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:122:  The parameter name "handler" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:123:  The parameter name "handler" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Philippe Normand]

LGTM apart from the style issue :)

[Martin Robinson]

Comment on attachment 82776 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82776&action=review

Looks good, but I have just a few small suggestions.

> WebCore/ChangeLog:14
> [phone]  Andoni Morales Alastruey  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Added 'location' property
> +        https://bugs.webkit.org/show_bug.cgi?id=54628
> +
> +        The 'location' property is used by gst_element_make_from_uri()
> +        to set the uri in the source element
> +
> +        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
> +        (webkit_web_src_class_init):
> +        (webKitWebSrcSetProperty):
> +        (webKitWebSrcGetProperty):

Please generate your ChangeLog with prepare-ChangeLog --bug <bugid>. Some of the tools will unfotunately choke if the format is incorrect.

> WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:119
> +static gboolean webKitWebSrcSetUri(GstURIHandler* handler, const gchar* uri);
> +static const gchar* webKitWebSrcGetUri(GstURIHandler* handler);

The argument names aren't necessary here.

> WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:206
> +    /* location property for gst_element_make_from_uri */

Please use complete sentences for comments.

> WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:298
> +        webKitWebSrcSetUri((GstURIHandler *)src, g_value_get_string(value));

Please use either static_cast or reinterpret_cast where appropriate.

> WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:328
> +        g_value_set_string(value, webKitWebSrcGetUri((GstURIHandler *) src));

Ditto.

[Andoni]

Created attachment 82959 [details]
Patch

[Andoni]

I have updated the patch with all your suggestions :)

[Martin Robinson]

Comment on attachment 82959 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82959&action=review

Great!

> WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

Generally you shoud explain here why tests are not needed. We can do that whil landing this though.

[Martin Robinson]

Philippe, do you mind landing this one?

[Philippe Normand]

Committed r79197: <http://trac.webkit.org/changeset/79197>