Bug 54625 – [chromium] GradientSkia: use the common Gradient stop sorting methods.

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[noel gordon]

Address a code FIXME.

[noel gordon]

Created attachment 82768 [details]
Patch

[James Robinson]

Comment on attachment 82768 [details]
Patch

R=me

[WebKit Commit Bot]

Comment on attachment 82768 [details]
Patch

Rejecting attachment 82768 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'land-a..." exit_code: 2

Last 500 characters of output:
c (refs/remotes/trunk)
	M	Source/WebCore/ChangeLog
	M	Source/WebCore/platform/graphics/skia/GradientSkia.cpp
r79063 = 29f47ae159022f5b8d71afc2ca3b29c700d3739a (refs/remotes/trunk)
	M	Source/WebKit2/ChangeLog
	M	Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
	M	Source/WebKit2/WebProcess/WebPage/WebPage.cpp
r79064 = 8c69a75bf9b2ef43953139bbda1848f2a4ca9f84 (refs/remotes/trunk)
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/trunk.

Full output: http://queues.webkit.org/results/7939200

[James Robinson]

Looks like this doesn't apply to ToT any more.  Would you mind merging+uploading, Noel?

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 82768 [details]:

http/tests/security/cross-frame-access-port-explicit-domain.html bug 54668 (author: [e-mail])
The commit-queue is continuing to process your patch.

[noel gordon]

(In reply to comment #4)
> Looks like this doesn't apply to ToT any more.  Would you mind merging+uploading, Noel?

No worries. I'm away for a week, and will merge+upload on my return.

[noel gordon]

Created attachment 84015 [details]
patch - merge and reupload

[WebKit Review Bot]

Attachment 84015 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/platform/graphics/skia/GradientSkia.cpp:118:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[noel gordon]

Created attachment 84016 [details]
patch - merge and reupload #2

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 84016 [details]:

http/tests/websocket/tests/close-on-navigate-new-location.html bug 55431 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 84016 [details]
patch - merge and reupload #2

Clearing flags on attachment: 84016

Committed r79950: <http://trac.webkit.org/changeset/79950>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/79950 might have broken SnowLeopard Intel Release (Build)