Bug 54621 - [EFL] Remove proxy feature of soup when proxy is null
Summary: [EFL] Remove proxy feature of soup when proxy is null
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-17 00:36 PST by Gyuyoung Kim
Modified: 2011-02-18 23:41 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.48 KB, patch)
2011-02-17 00:41 PST, Gyuyoung Kim 		tonikitoo: review+
tonikitoo: commit-queue-
Details | Formatted Diff | Diff
Fixed Patch (1.50 KB, patch)
2011-02-17 15:21 PST, Gyuyoung Kim 		tonikitoo: review+
Details | Formatted Diff | Diff
Fixed Patch (1.32 KB, patch)
2011-02-17 20:23 PST, Gyuyoung Kim 		gyuyoung.kim: commit-queue+
Details | Formatted Diff | Diff
Fixed Patch (1.32 KB, patch)
2011-02-17 20:25 PST, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2011-02-17 00:36:47 PST 
In void ewk_settings_proxy_uri_set(const char* proxy), it is better to remove proxy feature when parameter is NULL.
Comment 1 Gyuyoung Kim 2011-02-17 00:41:54 PST 
Created attachment 82763 [details]
Patch
Comment 2 Antonio Gomes 2011-02-17 05:55:38 PST 
Comment on attachment 82763 [details]
Patch

Please move "session" declaration line to withing the "if" block.
Comment 3 Gyuyoung Kim 2011-02-17 15:21:48 PST 
Created attachment 82869 [details]
Fixed Patch

>> Please move "session" declaration line to withing the "if" block.

Do you mean that the session declaration need to be moved to if block ?

I add "return" to if block. How do you think about it ? 

The session declaration should be declared regardless of proxy.
Comment 4 Antonio Gomes 2011-02-17 20:15:16 PST 
Comment on attachment 82869 [details]
Fixed Patch

In "removes proxy feature in soup." it should be "remove".
Comment 5 Gyuyoung Kim 2011-02-17 20:23:04 PST 
Created attachment 82909 [details]
Fixed Patch

I fix the wrong spelling. Thank you for your review.
Comment 6 Gyuyoung Kim 2011-02-17 20:25:29 PST 
Created attachment 82910 [details]
Fixed Patch

I add your name to reviewer field in Changelog. Thank you.
Comment 7 WebKit Commit Bot 2011-02-18 19:20:55 PST 
Comment on attachment 82910 [details]
Fixed Patch

Clearing flags on attachment: 82910

Committed r79070: <http://trac.webkit.org/changeset/79070>