Bug 54606 – [Chromium] Control-Up/Down do not scroll by page on Chrome/Mac

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

[Takashi Toyoshima]

http://code.google.com/p/chromium/issues/detail?id=68975

Control-Up/Down should be PageUp/Down on Mac.
It is in most programs (Xcode, Safari, etc.)

[Takashi Toyoshima]

Created attachment 82734 [details]
Patch

[Shinichiro Hamaji]

Adding [Chromium] prefix to the summary.

[Shinichiro Hamaji]

Comment on attachment 82734 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82734&action=review

r=me

I think you would want to set cq? when you ask a review for your patch.

> Source/WebKit/chromium/ChangeLog:5
> +        Control-Up/Down should be PageUp/Down on Mac.

I think it's nice to have prefixes for this kind of platform specific changes.

> Source/WebKit/chromium/src/WebViewImpl.cpp:809
> +    // Control-Up/Down should be PageUp/Downb on Mac.

s/Downb/Down/

[Takashi Toyoshima]

Created attachment 83440 [details]
Patch

[WebKit Review Bot]

Attachment 83440 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1

Source/WebKit/chromium/src/WebViewImpl.cpp:815:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Shinichiro Hamaji]

(In reply to comment #5)
> Attachment 83440 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1
> 
> Source/WebKit/chromium/src/WebViewImpl.cpp:815:  One line control clauses should not use braces.  [whitespace/braces] [4]
> Total errors found: 1 in 2 files

True... I'm wondering why this cannot be detected in the previous time.

[Takashi Toyoshima]

Created attachment 83441 [details]
Patch

[WebKit Review Bot]

Attachment 83441 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1

Source/WebKit/chromium/src/WebViewImpl.cpp:811:  More than one command on the same line in if  [whitespace/parens] [4]
Source/WebKit/chromium/src/WebViewImpl.cpp:812:  More than one command on the same line in if  [whitespace/parens] [4]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Takashi Toyoshima]

hum...
In my local environment, check-webkit-style could not detect this style check error as previous bot could not.

FYI
% svn info
Path: .
URL: http://svn.webkit.org/repository/webkit/trunk
Repository Root: http://svn.webkit.org/repository/webkit
Repository UUID: 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Revision: 78759
Node Kind: directory
Schedule: normal
Last Changed Author: [e-mail]
Last Changed Rev: 78759
Last Changed Date: 2011-02-16 18:28:10 -0800 (Wed, 16 Feb 2011)

[Shinichiro Hamaji]

Comment on attachment 83441 [details]
Patch

It looks like this check was fixed recently.

http://trac.webkit.org/changeset/79102

[Takashi Toyoshima]

Created attachment 83445 [details]
Patch

[Shinichiro Hamaji]

Comment on attachment 83445 [details]
Patch

Finally!

[Takashi Toyoshima]

Yes!
I'm sorry for bothering you;(

[WebKit Commit Bot]

Comment on attachment 83445 [details]
Patch

Clearing flags on attachment: 83445

Committed r79427: <http://trac.webkit.org/changeset/79427>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/79427 might have broken Windows Release (Build) and Windows Debug (Build)