Bug 54596 - new-run-webkit-tests: enable multiple processes by default on mac
Summary: new-run-webkit-tests: enable multiple processes by default on mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-16 15:36 PST by Dirk Pranke
Modified: 2011-02-21 18:03 PST (History)
10 users (show)

See Also:


Attachments
Patch (1.84 KB, patch)
2011-02-16 15:37 PST, Dirk Pranke
no flags Details | Formatted Diff | Diff
Patch (8.53 KB, patch)
2011-02-18 18:13 PST, Dirk Pranke
jamesr: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2011-02-16 15:36:49 PST
new-run-webkit-tests: enable multiple processes by default on mac
Comment 1 Dirk Pranke 2011-02-16 15:37:11 PST
Created attachment 82712 [details]
Patch
Comment 2 Ojan Vafai 2011-02-17 00:01:45 PST
Comment on attachment 82712 [details]
Patch

Fingers crossed!
Comment 3 Dirk Pranke 2011-02-18 15:53:47 PST
Committed r79047: <http://trac.webkit.org/changeset/79047>
Comment 4 Andrew Wilson 2011-02-18 17:16:02 PST
Reverted r79047 for reason:

Broke canary bots - please watch the canaries the next time you land this

Committed r79055: <http://trac.webkit.org/changeset/79055>
Comment 5 Dirk Pranke 2011-02-18 17:46:01 PST
Whoops. I didn't handle the Leopard/Python 2.5 "multiprocessing isn't available" case properly, unfortunately.

Sorry about the canary miss ... I was at a presentation.
Comment 6 Dirk Pranke 2011-02-18 18:13:08 PST
Created attachment 83042 [details]
Patch
Comment 7 Dimitri Glazkov (Google) 2011-02-18 18:15:49 PST
So exciting!
Comment 8 Dirk Pranke 2011-02-18 18:18:49 PST
Committed r79062: <http://trac.webkit.org/changeset/79062>
Comment 10 Dirk Pranke 2011-02-21 13:27:33 PST
investigating ...
Comment 11 Dirk Pranke 2011-02-21 18:03:05 PST
(In reply to comment #10)
> investigating ...

rniwa filed chromium bug http://crbug.com/73651 . I would prefer to triage the http failures there and leave this bug alone for now ...