RESOLVED FIXED Bug 54584
Summary: HTML5 <details> and <summary>: HTMLSummaryElement 
https://bugs.webkit.org/show_bug.cgi?id=54584
Summary Summary: HTML5 <details> and <summary>: HTMLSummaryElement
Luiz Agostini
Reported 2011-02-16 13:57:41 PST
Adding class HTMLSummaryElement to build systems.
Attachments
patch (14.62 KB, patch)
2011-02-16 14:07 PST, Luiz Agostini 		tkent: review-
DetailsFormatted DiffDiff
patch (14.63 KB, patch)
2011-02-17 08:07 PST, Luiz Agostini 		no flags
DetailsFormatted DiffDiff
patch (14.77 KB, patch)
2011-02-17 08:15 PST, Luiz Agostini 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Luiz Agostini
Comment 1 2011-02-16 14:07:12 PST
Created attachment 82690 [details] patch
WebKit Review Bot
Comment 2 2011-02-16 14:09:20 PST
Attachment 82690 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebCore/html/HTMLSummaryElement.cpp:21: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Source/WebCore/html/HTMLSummaryElement.cpp:22: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Source/WebCore/html/HTMLSummaryElement.h:30: The parameter name "document" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 3 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 3 2011-02-16 14:18:28 PST
Attachment 82690 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7927332
Kent Tamura
Comment 4 2011-02-17 06:38:13 PST
Comment on attachment 82690 [details] patch Why HTMLSummaryElement.{cpp,h} are needed? ChangeLog should explain it. Please fix style errors.
Luiz Agostini
Comment 5 2011-02-17 08:07:09 PST
Created attachment 82809 [details] patch
Luiz Agostini
Comment 6 2011-02-17 08:15:50 PST
Created attachment 82811 [details] patch
Luiz Agostini
Comment 7 2011-02-17 09:15:40 PST
Latest patch just adds some explanations to ChangeLog.
Luiz Agostini
Comment 8 2011-02-17 10:28:43 PST
rationale: https://bugs.webkit.org/show_bug.cgi?id=51071#c43
Luiz Agostini
Comment 9 2011-02-17 13:49:45 PST
Committed r78914: <http://trac.webkit.org/changeset/78914>
Note You need to log in before you can comment on or make changes to this bug.