Bug 54577 - [Qt] Tiles are not created for webkit2 after r77286.
Summary: [Qt] Tiles are not created for webkit2 after r77286.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2011-02-16 12:47 PST by Yael
Modified: 2011-02-16 20:27 PST (History)
2 users (show)

See Also:


Attachments
Patch. (2.87 KB, patch)
2011-02-16 12:52 PST, Yael
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yael 2011-02-16 12:47:51 PST
When using the default tile size of 1024x1024, only one tile is created.
What seems to be a typo in r77286 causes this one tile to not be created. A patch is coming soon.
Comment 1 Yael 2011-02-16 12:52:57 PST
Created attachment 82679 [details]
Patch.
Comment 2 Andreas Kling 2011-02-16 13:03:29 PST
Comment on attachment 82679 [details]
Patch.

D'oh! r=me
Comment 3 WebKit Commit Bot 2011-02-16 18:56:25 PST
Comment on attachment 82679 [details]
Patch.

Rejecting attachment 82679 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'land-a..." exit_code: 1

Last 500 characters of output:
ommit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run
    step(tool, options).run(state)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 57, in run
    if self._has_valid_reviewer(changelog_entry):
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 42, in _has_valid_reviewer
    if changelog_entry.reviewer():
AttributeError: 'NoneType' object has no attribute 'reviewer'

Full output: http://queues.webkit.org/results/7927453
Comment 4 WebKit Commit Bot 2011-02-16 20:27:20 PST
Comment on attachment 82679 [details]
Patch.

Clearing flags on attachment: 82679

Committed r78783: <http://trac.webkit.org/changeset/78783>
Comment 5 WebKit Commit Bot 2011-02-16 20:27:24 PST
All reviewed patches have been landed.  Closing bug.