RESOLVED INVALID Bug 54569
Potential Null pointer dereference checks 
https://bugs.webkit.org/show_bug.cgi?id=54569
Summary Potential Null pointer dereference checks
sangeetha.sugavanam
Reported 2011-02-16 10:32:47 PST
This bug adds some null pointer checks for potential null pointer dereferences in the code.
Attachments
patch fixing potential null pointer dereferences (2.78 KB, patch)
2011-02-17 06:36 PST, sangeetha.sugavanam 		no flags
DetailsFormatted DiffDiff
Patch for potential null pointer dereferences (3.06 KB, patch)
2011-02-17 08:12 PST, sangeetha.sugavanam 		kling: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
sangeetha.sugavanam
Comment 1 2011-02-17 06:36:35 PST
Created attachment 82791 [details] patch fixing potential null pointer dereferences
sangeetha.sugavanam
Comment 2 2011-02-17 08:12:38 PST
Created attachment 82810 [details] Patch for potential null pointer dereferences
Andreas Kling
Comment 3 2011-02-17 08:27:22 PST
Comment on attachment 82810 [details] Patch for potential null pointer dereferences These are two completely unrelated changes and should not be done in the same patch. You need to explain in the ChangeLog what you are changing and why. And if possible, a layout test should be added that triggers a bug without the change, otherwise please explain why it is not testable.
Alexey Proskuryakov
Comment 4 2011-02-17 09:23:03 PST
The second change in particular looks wrong to me. FileInputType::files() never returns null - it's just difficult for automated code checking tools to discover.
Benjamin Poulain
Comment 5 2011-02-22 05:50:52 PST
Closing the bug, no point at keeping this open.
Note You need to log in before you can comment on or make changes to this bug.