Bug 54565 - syncSoftwareCanvas with SKIA_GPU enabled should only make context current
Summary: syncSoftwareCanvas with SKIA_GPU enabled should only make context current
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-16 09:57 PST by Brian Salomon
Modified: 2011-02-16 17:11 PST (History)
5 users (show)

See Also:

Attachments
patch to make syncSoftwareCanvas call makeContextCurrent (1.22 KB, patch)
2011-02-16 10:00 PST, Brian Salomon 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Salomon 2011-02-16 09:57:21 PST 
Currently PlatformContext::syncSoftwareCanvas binds an FBO externally to Skia's gpu backend. This confuses the backend because resetContext() is not called. Moreover, the skia backend can bind the correct FBO itself when it is invoked to draw. We really just need to make the GC3D context current before drawing through Skia.
Comment 1 Brian Salomon 2011-02-16 10:00:12 PST 
Created attachment 82657 [details]
patch to make syncSoftwareCanvas call makeContextCurrent
Comment 2 Brian Salomon 2011-02-16 10:13:18 PST 
Adding Vangelis, Ken, and Mike to cc.
Comment 3 Vangelis Kokkevis 2011-02-16 13:25:03 PST 
This looks good although I think we won't have a complete solution until bug# 54327 is fixed.
Comment 4 WebKit Commit Bot 2011-02-16 17:11:03 PST 
Comment on attachment 82657 [details]
patch to make syncSoftwareCanvas call makeContextCurrent

Clearing flags on attachment: 82657

Committed r78754: <http://trac.webkit.org/changeset/78754>
Comment 5 WebKit Commit Bot 2011-02-16 17:11:07 PST 
All reviewed patches have been landed.  Closing bug.