We have a number of functions from different domains in single InspectorBackend instance. I'd be better to split the functions by domain. As example 'evaluate' will be moved from InspectorBackend to InspectorBackend.Runtime container.
Created attachment 82641 [details] [patch] initial version
Created attachment 82650 [details] [patch] second version In this version all the functions are accessible via a conainer for their domain. original: InspectorBackend.evaluate("lalala"); new version: RuntimeAgent.evaluate("lalala");
Comment on attachment 82650 [details] [patch] second version View in context: https://bugs.webkit.org/attachment.cgi?id=82650&action=review > LayoutTests/ChangeLog:9 > + I'd be better to split the functions by their domains. I'd -> It'd > Source/WebCore/inspector/CodeGeneratorInspector.pm:628 > + window[agentName] = []; window[agentName] should be Object not Array. r- for this.
Created attachment 82651 [details] [patch] third version comments addressed
Comment on attachment 82651 [details] [patch] third version Clearing flags on attachment: 82651 Committed r78717: <http://trac.webkit.org/changeset/78717>
All reviewed patches have been landed. Closing bug.