RESOLVED FIXED 54558
Web Inspector: split all the functions of Inspector backend API by domain. 
https://bugs.webkit.org/show_bug.cgi?id=54558
Summary Web Inspector: split all the functions of Inspector backend API by domain.
Ilya Tikhonovsky
Reported 2011-02-16 08:08:34 PST
We have a number of functions from different domains in single InspectorBackend instance. I'd be better to split the functions by domain. As example 'evaluate' will be moved from InspectorBackend to InspectorBackend.Runtime container.
Attachments
[patch] initial version (82.12 KB, patch)
2011-02-16 08:12 PST, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
[patch] second version (80.03 KB, patch)
2011-02-16 09:02 PST, Ilya Tikhonovsky 		yurys: review-
DetailsFormatted DiffDiff
[patch] third version (79.38 KB, patch)
2011-02-16 09:13 PST, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2011-02-16 08:12:58 PST
Created attachment 82641 [details] [patch] initial version
Ilya Tikhonovsky
Comment 2 2011-02-16 09:02:35 PST
Created attachment 82650 [details] [patch] second version In this version all the functions are accessible via a conainer for their domain. original: InspectorBackend.evaluate("lalala"); new version: RuntimeAgent.evaluate("lalala");
Yury Semikhatsky
Comment 3 2011-02-16 09:07:31 PST
Comment on attachment 82650 [details] [patch] second version View in context: https://bugs.webkit.org/attachment.cgi?id=82650&action=review > LayoutTests/ChangeLog:9 > + I'd be better to split the functions by their domains. I'd -> It'd > Source/WebCore/inspector/CodeGeneratorInspector.pm:628 > + window[agentName] = []; window[agentName] should be Object not Array. r- for this.
Ilya Tikhonovsky
Comment 4 2011-02-16 09:13:43 PST
Created attachment 82651 [details] [patch] third version comments addressed
Ilya Tikhonovsky
Comment 5 2011-02-16 09:18:16 PST
Comment on attachment 82651 [details] [patch] third version Clearing flags on attachment: 82651 Committed r78717: <http://trac.webkit.org/changeset/78717>
Ilya Tikhonovsky
Comment 6 2011-02-16 09:18:28 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.