Bug 54554 - REGRESSION(r78678): Breaks NaCl tests in Chromium (Requested by mnaganov on #webkit).
Summary: REGRESSION(r78678): Breaks NaCl tests in Chromium (Requested by mnaganov on #...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: WebKit Review Bot
URL:
Keywords:
Depends on:
Blocks: 54489
  Show dependency tree / graph
 
Reported: 2011-02-16 07:15 PST by WebKit Review Bot
Modified: 2011-02-21 02:09 PST (History)
3 users (show)

See Also:

Attachments
ROLLOUT of r78678 (4.75 KB, patch)
2011-02-16 07:16 PST, WebKit Review Bot 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2011-02-16 07:15:40 PST 
http://trac.webkit.org/changeset/78678 broke the build:
Breaks NaCl tests in Chromium (Requested by mnaganov on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2011-02-16 07:16:07 PST 
Created attachment 82629 [details]
ROLLOUT of r78678

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Mikhail Naganov 2011-02-16 07:21:01 PST 
Manually committed http://trac.webkit.org/changeset/78705
Comment 3 Mikhail Naganov 2011-02-18 02:02:03 PST 
Ah, I'm sorry for not providing you this info at the first hand.
Two tests were failing (crashing):
  - NaClUITest.PPAPIHelloWorld from nacl_ui_test.cc
  - NaClSandboxTest.NaClOuterSBTest from nacl_sandbox_test.cc

And this was easily reproducible on my Linux machine -- I was able to bisect the roll to find out that this was because of your change.
Comment 4 David Levin 2011-02-18 05:40:24 PST 
Comment on attachment 82629 [details]
ROLLOUT of r78678

Cleared cq? as this was already landed.
Comment 5 Bill Budge 2011-02-18 14:04:58 PST 
Mikhail,

I am trying to set breakpoints on the changed code to see why this simple change causes a crash. They never get hit, so I suspect I'm not attached to the right process. Are there any tips you can give me for how to attach (in Visual Studio right now) after the process is created but before too much code gets run?

(In reply to comment #3)
> Ah, I'm sorry for not providing you this info at the first hand.
> Two tests were failing (crashing):
>   - NaClUITest.PPAPIHelloWorld from nacl_ui_test.cc
>   - NaClSandboxTest.NaClOuterSBTest from nacl_sandbox_test.cc
> 
> And this was easily reproducible on my Linux machine -- I was able to bisect the roll to find out that this was because of your change.
Comment 6 Mikhail Naganov 2011-02-21 02:09:02 PST 
Hi Bill,

Take a look at this page: http://dev.chromium.org/developers/how-tos/debugging
I used '--renderer-startup-dialog --no-sandbox' flags to get renderer process to stop and show me its PID before it does anything important. You might need to modify the code that starts Chromium from the test.