WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED DUPLICATE of
bug 54023
54550
remove assert when decoding non-premultiplied images
https://bugs.webkit.org/show_bug.cgi?id=54550
Summary
remove assert when decoding non-premultiplied images
Mike Reed
Reported
2011-02-16 06:06:28 PST
The standard way to create a 32bit pixel in skia is to call SkPackARGB32(a,r,g,b). This puts the components in the correct (compile-time) order, and also (in the Debug build) asserts that the components are legal for premultiplied. i.e. r <= a, g <= a, b <= a. This test makes sense for Skia in general, as it only supports premultiplied bitmaps today. However, WebGL is using the same decoder and bitmap to store images that will be passed directly to opengl, and opengl supports premultiplied and non-premultiplied. This change calls a new version of the pack macro: SkPackARGB32NoCheck(a,r,g,b) which skips the asserts on the component values (since any values can be valid for opengl).
Attachments
Add attachment
proposed patch, testcase, etc.
Mike Reed
Comment 1
2011-02-16 06:12:33 PST
*** This bug has been marked as a duplicate of
bug 54023
***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug