Bug 54549 - [NRWT] Fix environment setup on Qt port
Summary: [NRWT] Fix environment setup on Qt port
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Gabor Rapcsanyi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-16 05:39 PST by Gabor Rapcsanyi
Modified: 2011-02-17 03:13 PST (History)
5 users (show)

See Also:

Attachments
proposed patch (1.08 KB, patch)
2011-02-16 05:45 PST, Gabor Rapcsanyi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Rapcsanyi 2011-02-16 05:39:34 PST 
Fix the environment setup on Qt port.
Comment 1 Gabor Rapcsanyi 2011-02-16 05:45:48 PST 
Created attachment 82619 [details]
proposed patch
Comment 2 WebKit Commit Bot 2011-02-16 17:06:58 PST 
Comment on attachment 82619 [details]
proposed patch

Rejecting attachment 82619 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'land-a..." exit_code: 1

Last 500 characters of output:
ommit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run
    step(tool, options).run(state)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 57, in run
    if self._has_valid_reviewer(changelog_entry):
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 42, in _has_valid_reviewer
    if changelog_entry.reviewer():
AttributeError: 'NoneType' object has no attribute 'reviewer'

Full output: http://queues.webkit.org/results/7927419
Comment 3 Csaba Osztrogonác 2011-02-17 01:38:15 PST 
Comment on attachment 82619 [details]
proposed patch

one more attempt :)
Comment 4 WebKit Commit Bot 2011-02-17 03:13:39 PST 
Comment on attachment 82619 [details]
proposed patch

Clearing flags on attachment: 82619

Committed r78807: <http://trac.webkit.org/changeset/78807>
Comment 5 WebKit Commit Bot 2011-02-17 03:13:45 PST 
All reviewed patches have been landed.  Closing bug.