Bug 54545 - DragController should use Color::serialized() when passing colors to CSSStyleDeclaration
Summary: DragController should use Color::serialized() when passing colors to CSSStyle...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks: 54539
  Show dependency tree / graph
 
Reported: 2011-02-16 03:50 PST by Andreas Kling
Modified: 2011-02-19 19:10 PST (History)
1 user (show)

See Also:

Attachments
Proposed patch (1.45 KB, patch)
2011-02-16 03:53 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-02-16 03:50:59 PST 
DragController::concludeEditDrag() currently passes the string returned by Color::nameForRenderTreeAsText() to CSSStyleDeclaration::setProperty(). If the color has an alpha value, the string will be in #RRGGBBAA format which is not valid CSS.
Comment 1 Andreas Kling 2011-02-16 03:53:44 PST 
Created attachment 82612 [details]
Proposed patch
Comment 2 Andreas Kling 2011-02-19 19:10:43 PST 
Comment on attachment 82612 [details]
Proposed patch

Clearing flags on attachment: 82612

Committed r79145: <http://trac.webkit.org/changeset/79145>
Comment 3 Andreas Kling 2011-02-19 19:10:49 PST 
All reviewed patches have been landed.  Closing bug.