Bug 54537 - [Gtk] Add support for layoutTestController.setWillSendRequestClearHeader
Summary: [Gtk] Add support for layoutTestController.setWillSendRequestClearHeader
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Sergio Villar Senin
Depends on:
Reported: 2011-02-16 01:30 PST by Sergio Villar Senin
Modified: 2011-02-16 10:24 PST (History)
3 users (show)

See Also:

Patch (6.06 KB, patch)
2011-02-16 01:35 PST, Sergio Villar Senin
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2011-02-16 01:30:54 PST
[Gtk] Add support for layoutTestController.setWillSendRequestClearHeader
Comment 1 Sergio Villar Senin 2011-02-16 01:35:14 PST
Created attachment 82604 [details]
Comment 2 Sergio Villar Senin 2011-02-16 01:37:37 PST
I know ChangeLogs are not OK. I used webkit-path upload to upload the patch and didn't realize that I had to edit both. I guess I should change them before committing
Comment 3 Martin Robinson 2011-02-16 08:29:18 PST
Comment on attachment 82604 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=82604&action=review

Great stuff. Please consider the following changes befor committing.

> Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:95
> +    GHashTable* headersHash = g_hash_table_new(g_str_hash, g_str_equal);

I think I'd rather this be a Vector<String> or a HashMap<String, int>. You're already converting to String below so you can just reuse that. That will allow you to remove a few lines below.

> Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:1015
> +static void willSendRequestCallback(WebKitWebView* webView, WebKitWebFrame*, WebKitWebResource* resource, WebKitNetworkRequest* request, WebKitNetworkResponse* redirectResponse)

You can remove the "resource' and "redirectResponse" paramter names.
Comment 4 Sergio Villar Senin 2011-02-16 09:47:39 PST
Committed r78718: <http://trac.webkit.org/changeset/78718>
Comment 5 WebKit Review Bot 2011-02-16 10:24:37 PST
http://trac.webkit.org/changeset/78718 might have broken Qt Linux Release
The following tests are not passing: