Bug 54537 – [Gtk] Add support for layoutTestController.setWillSendRequestClearHeader

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sergio Villar Senin]

[Gtk] Add support for layoutTestController.setWillSendRequestClearHeader

[Sergio Villar Senin]

Created attachment 82604 [details]
Patch

[Sergio Villar Senin]

I know ChangeLogs are not OK. I used webkit-path upload to upload the patch and didn't realize that I had to edit both. I guess I should change them before committing

[Martin Robinson]

Comment on attachment 82604 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82604&action=review

Great stuff. Please consider the following changes befor committing.

> Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:95
> +    GHashTable* headersHash = g_hash_table_new(g_str_hash, g_str_equal);

I think I'd rather this be a Vector<String> or a HashMap<String, int>. You're already converting to String below so you can just reuse that. That will allow you to remove a few lines below.

> Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:1015
> +static void willSendRequestCallback(WebKitWebView* webView, WebKitWebFrame*, WebKitWebResource* resource, WebKitNetworkRequest* request, WebKitNetworkResponse* redirectResponse)

You can remove the "resource' and "redirectResponse" paramter names.

[Sergio Villar Senin]

Committed r78718: <http://trac.webkit.org/changeset/78718>

[WebKit Review Bot]

http://trac.webkit.org/changeset/78718 might have broken Qt Linux Release
The following tests are not passing:
media/controls-without-preload.html