[Gtk] Add support for layoutTestController.setWillSendRequestClearHeader
Created attachment 82604 [details]
I know ChangeLogs are not OK. I used webkit-path upload to upload the patch and didn't realize that I had to edit both. I guess I should change them before committing
Comment on attachment 82604 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=82604&action=review
Great stuff. Please consider the following changes befor committing.
> + GHashTable* headersHash = g_hash_table_new(g_str_hash, g_str_equal);
I think I'd rather this be a Vector<String> or a HashMap<String, int>. You're already converting to String below so you can just reuse that. That will allow you to remove a few lines below.
> +static void willSendRequestCallback(WebKitWebView* webView, WebKitWebFrame*, WebKitWebResource* resource, WebKitNetworkRequest* request, WebKitNetworkResponse* redirectResponse)
You can remove the "resource' and "redirectResponse" paramter names.
Committed r78718: <http://trac.webkit.org/changeset/78718>
http://trac.webkit.org/changeset/78718 might have broken Qt Linux Release
The following tests are not passing: