Bug 54518 - Fix race condition in JavaScriptAudioNode
Summary: Fix race condition in JavaScriptAudioNode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-15 17:54 PST by Chris Rogers
Modified: 2011-02-15 18:13 PST (History)
1 user (show)

See Also:


Attachments
Patch (1.33 KB, patch)
2011-02-15 17:56 PST, Chris Rogers
kbr: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2011-02-15 17:54:20 PST
Fix race condition in JavaScriptAudioNode
Comment 1 Chris Rogers 2011-02-15 17:56:06 PST
Created attachment 82564 [details]
Patch
Comment 2 Chris Rogers 2011-02-15 17:58:36 PST
m_isRequestOutstanding needs to be set before callOnMainThread() to avoid race condition with its value being set in the main thread.

This fixes chromium bug:
http://code.google.com/p/chromium/issues/detail?id=71702

The race condition could also happen for other ports.
Comment 3 Kenneth Russell 2011-02-15 18:01:12 PST
Comment on attachment 82564 [details]
Patch

Looks fine to me. Tricky.
Comment 4 Chris Rogers 2011-02-15 18:13:23 PST
Committed r78671: <http://trac.webkit.org/changeset/78671>