Bug 54511 – Allow acceleratesDrawing for WebKit2

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Matthew Delaney]

Allow acceleratesDrawing for WebKit2, plumb through setters/getters.

[Matthew Delaney]

Created attachment 82552 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 82552 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82552&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests. Can't really test this.

Really, or not at all?

> Source/WebCore/ChangeLog:13
> +        ^^ plumb through acceleratesDrawing

Don't use ^^, and use Sentence case.

> Source/WebCore/rendering/RenderLayerCompositor.cpp:1295
> -        return canvas->renderingContext() && canvas->renderingContext()->isAccelerated();
> +         return canvas->renderingContext() && canvas->renderingContext()->isAccelerated();

Spurious whitespace change here.

> Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp:294
> +    if (graphicsLayer)
> +        m_layerTreeHost->setRootCompositingLayer(graphicsLayer);

You can remove this change now.

> Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp:312
> +    if (m_webPage->corePage()->settings()->acceleratedDrawingEnabled())
> +        return;

This is a bit hacky; we should clean up this code.

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1366
> +    settings->setAcceleratedDrawingEnabled(store.getBoolValueForKey(false));

Why the store.getBoolValueForKey(false)?

> Source/WebKit/mac/WebView/WebPreferences.mm:361
> +        [NSNumber numberWithBool:YES],  WebKitAcceleratedDrawingEnabledPreferenceKey,

I think it should default to off.

[Build Bot]

Attachment 82552 [details] did not build on win:
Build output: http://queues.webkit.org/results/7918100

[Matthew Delaney]

Created attachment 82736 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 82736 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82736&action=review

r=me bug DrawingAreaImpl::exitAcceleratedCompositing() needs fixing.

> Source/WebCore/ChangeLog:12
> +        * WebCore.exp.in:Plumb through acceleratesDrawing
> +        * page/Settings.cpp:Plumb through acceleratesDrawing
> +        * page/Settings.h: Plumb through acceleratesDrawing

Be consistent about putting a space after the colon.

> Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp:316
> +    m_webPage->corePage()->settings()->acceleratedDrawingEnabled();

This isn't doing anything.

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/78788

[WebKit Review Bot]

http://trac.webkit.org/changeset/78788 might have broken GTK Linux 64-bit Debug