Bug 54511 - Allow acceleratesDrawing for WebKit2
Summary: Allow acceleratesDrawing for WebKit2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Matthew Delaney
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-15 16:53 PST by Matthew Delaney
Modified: 2011-02-17 00:50 PST (History)
6 users (show)

See Also:


Attachments
Patch (14.43 KB, patch)
2011-02-15 17:01 PST, Matthew Delaney
no flags Details | Formatted Diff | Diff
Patch (13.83 KB, patch)
2011-02-16 18:57 PST, Matthew Delaney
simon.fraser: review+
simon.fraser: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Delaney 2011-02-15 16:53:54 PST
Allow acceleratesDrawing for WebKit2, plumb through setters/getters.
Comment 1 Matthew Delaney 2011-02-15 17:01:05 PST
Created attachment 82552 [details]
Patch
Comment 2 Simon Fraser (smfr) 2011-02-15 17:08:56 PST
Comment on attachment 82552 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82552&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests. Can't really test this.

Really, or not at all?

> Source/WebCore/ChangeLog:13
> +        ^^ plumb through acceleratesDrawing

Don't use ^^, and use Sentence case.

> Source/WebCore/rendering/RenderLayerCompositor.cpp:1295
> -        return canvas->renderingContext() && canvas->renderingContext()->isAccelerated();
> +         return canvas->renderingContext() && canvas->renderingContext()->isAccelerated();

Spurious whitespace change here.

> Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp:294
> +    if (graphicsLayer)
> +        m_layerTreeHost->setRootCompositingLayer(graphicsLayer);

You can remove this change now.

> Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp:312
> +    if (m_webPage->corePage()->settings()->acceleratedDrawingEnabled())
> +        return;

This is a bit hacky; we should clean up this code.

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1366
> +    settings->setAcceleratedDrawingEnabled(store.getBoolValueForKey(false));

Why the store.getBoolValueForKey(false)?

> Source/WebKit/mac/WebView/WebPreferences.mm:361
> +        [NSNumber numberWithBool:YES],  WebKitAcceleratedDrawingEnabledPreferenceKey,

I think it should default to off.
Comment 3 Build Bot 2011-02-15 18:27:09 PST
Attachment 82552 [details] did not build on win:
Build output: http://queues.webkit.org/results/7918100
Comment 4 Matthew Delaney 2011-02-16 18:57:26 PST
Created attachment 82736 [details]
Patch
Comment 5 Simon Fraser (smfr) 2011-02-16 20:16:10 PST
Comment on attachment 82736 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82736&action=review

r=me bug DrawingAreaImpl::exitAcceleratedCompositing() needs fixing.

> Source/WebCore/ChangeLog:12
> +        * WebCore.exp.in:Plumb through acceleratesDrawing
> +        * page/Settings.cpp:Plumb through acceleratesDrawing
> +        * page/Settings.h: Plumb through acceleratesDrawing

Be consistent about putting a space after the colon.

> Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp:316
> +    m_webPage->corePage()->settings()->acceleratedDrawingEnabled();

This isn't doing anything.
Comment 6 Simon Fraser (smfr) 2011-02-16 20:54:43 PST
http://trac.webkit.org/changeset/78788
Comment 7 WebKit Review Bot 2011-02-17 00:50:18 PST
http://trac.webkit.org/changeset/78788 might have broken GTK Linux 64-bit Debug