RESOLVED FIXED54510
Implement WKPluginSiteDataManagerGetSitesWithData 
https://bugs.webkit.org/show_bug.cgi?id=54510
Summary Implement WKPluginSiteDataManagerGetSitesWithData
Anders Carlsson
Reported 2011-02-15 16:41:20 PST
Implement WKPluginSiteDataManagerGetSitesWithData
Attachments
Patch (26.54 KB, patch)
2011-02-15 16:45 PST, Anders Carlsson 		jhoneycutt: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2011-02-15 16:45:42 PST
Created attachment 82550 [details] Patch
Jon Honeycutt
Comment 2 2011-02-15 16:48:45 PST
Comment on attachment 82550 [details] Patch r=me
Anders Carlsson
Comment 3 2011-02-15 16:49:31 PST
Committed r78647: <http://trac.webkit.org/changeset/78647>
Darin Adler
Comment 4 2011-02-15 16:50:01 PST
Comment on attachment 82550 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82550&action=review > Source/WebKit2/UIProcess/Plugins/WebPluginSiteDataManager.cpp:96 > + RefPtr<ImmutableArray> resultArray = ImmutableArray::adopt(sitesWK); > + callback->performCallbackWithReturnValue(resultArray.get()); The local variable here doesn’t seem to do any good. > Source/WebKit2/UIProcess/Plugins/WebPluginSiteDataManager.h:33 > +#include <wtf/PassRefPtr.h> Should only need Forward.h since you don’t do anything with PassRefPtr in this header. > Source/WebKit2/UIProcess/Plugins/WebPluginSiteDataManager.h:39 > +namespace CoreIPC { > +class ArgumentDecoder; > +class Connection; > +class MessageID; > +} Yuck, I guess the script is telling you do do this. > Source/WebKit2/WebProcess/WebProcess.cpp:658 > + Vector<String> sites; > + copyToVector(sitesSet, sites); Would be nice to sort this. I hate to have an API that returns a vector in a random order.
Note You need to log in before you can comment on or make changes to this bug.