Implement WKPluginSiteDataManagerGetSitesWithData

[Anders Carlsson]

Implement WKPluginSiteDataManagerGetSitesWithData

[Anders Carlsson]

Created attachment 82550 [details]
Patch

[Jon Honeycutt]

Comment on attachment 82550 [details]
Patch

r=me

[Anders Carlsson]

Committed r78647: <http://trac.webkit.org/changeset/78647>

[Darin Adler]

Comment on attachment 82550 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82550&action=review

> Source/WebKit2/UIProcess/Plugins/WebPluginSiteDataManager.cpp:96
> +    RefPtr<ImmutableArray> resultArray = ImmutableArray::adopt(sitesWK);
> +    callback->performCallbackWithReturnValue(resultArray.get());

The local variable here doesn’t seem to do any good.

> Source/WebKit2/UIProcess/Plugins/WebPluginSiteDataManager.h:33
> +#include <wtf/PassRefPtr.h>

Should only need Forward.h since you don’t do anything with PassRefPtr in this header.

> Source/WebKit2/UIProcess/Plugins/WebPluginSiteDataManager.h:39
> +namespace CoreIPC {
> +class ArgumentDecoder;
> +class Connection;
> +class MessageID;
> +}

Yuck, I guess the script is telling you do do this.

> Source/WebKit2/WebProcess/WebProcess.cpp:658
> +    Vector<String> sites;
> +    copyToVector(sitesSet, sites);

Would be nice to sort this. I hate to have an API that returns a vector in a random order.