Bug 54502 - media/audio-delete-while-slider-thumb-clicked.html failing on Windows since r78562
Summary: media/audio-delete-while-slider-thumb-clicked.html failing on Windows since r...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords: LayoutTestFailure, PlatformOnly, Regression
Depends on:
Blocks:
 
Reported: 2011-02-15 15:26 PST by Steve Falkenburg
Modified: 2011-02-16 05:55 PST (History)
2 users (show)

See Also:

Attachments
proposed patch (1.72 KB, patch)
2011-02-16 03:05 PST, Philippe Normand 		aroben: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Falkenburg 2011-02-15 15:26:58 PST 
media/audio-delete-while-slider-thumb-clicked.html failing on Windows since r78562.

Change http://trac.webkit.org/changeset/78562 refactored the test to use oncanplaythrough. This caused the test to fail on Windows.
Comment 1 Steve Falkenburg 2011-02-15 15:34:36 PST 
Failure message:

CONSOLE MESSAGE: line 38: TypeError: 'null' is not an object (evaluating 'audio.parentNode')
Comment 2 Adam Roben (:aroben) 2011-02-15 15:53:51 PST 
We normally check in Windows-specific expected failing results in cases like this where the test fails the same way every time and isn't crashing or timing out. That way we can notice when the behavior of the test changes (e.g., if someone fixes it).
Comment 3 Philippe Normand 2011-02-16 03:05:16 PST 
Created attachment 82607 [details]
proposed patch
Comment 4 Philippe Normand 2011-02-16 03:06:43 PST 
Can someone on Windows please try this patch? I think the seeking event was triggered twice so the test tried to delete the audio element twice, leading to that "undefined" error.
Comment 5 Adam Roben (:aroben) 2011-02-16 05:00:21 PST 
Comment on attachment 82607 [details]
proposed patch

This fixes the test on Windows for me. Please remove the test from LayoutTests/platform/win/Skipped, too.
Comment 6 Philippe Normand 2011-02-16 05:55:02 PST 
Committed r78701: <http://trac.webkit.org/changeset/78701>