Bug 54498 - Layers stick around in DrawingAreaImpl until we switch out of compositing
Summary: Layers stick around in DrawingAreaImpl until we switch out of compositing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-15 14:50 PST by Simon Fraser (smfr)
Modified: 2011-02-15 15:02 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.50 KB, patch)
2011-02-15 14:56 PST, Simon Fraser (smfr) 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2011-02-15 14:50:05 PST 
If DrawingAreaImpl delays its exit from compositing (say if you change m_exitCompositingTimer.startOneShot() to use 3 seconds), then compositing layers stick around for that time, even after they should have been hidden.
Comment 1 Simon Fraser (smfr) 2011-02-15 14:56:42 PST 
Created attachment 82527 [details]
Patch
Comment 2 Darin Adler 2011-02-15 14:57:50 PST 
Comment on attachment 82527 [details]
Patch

Does this mean we’ll see something different onscreen at the moment setRootCompositingLayer is called?
Comment 3 Simon Fraser (smfr) 2011-02-15 15:00:44 PST 
I think the zero-delay timer masked this issue, or at least just caused one frame of badness.
Comment 4 Simon Fraser (smfr) 2011-02-15 15:02:01 PST 
http://trac.webkit.org/changeset/78623