Bug 54497 – [chromium] Canvas-2D-GPU fails on clearRect() w/identity transform and non-full-canvas rectangle

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Stephen White]

[chromium] Canvas-2D-GPU fails on clearRect() w/identity transform and non-full-canvas rectangle

[Stephen White]

Created attachment 82523 [details]
Patch

[Stephen White]

See fast/canvas/canvas-strokeRect.html.

[James Robinson]

Comment on attachment 82523 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82523&action=review

R- for the changelog, but code looks good. Is there a test_expectations.txt line we could flip for this test?

> Source/WebCore/ChangeLog:8
> +        When doing GPU-Canvas2D clearRect() using the fast path (glClear()),
> +        we were not correctly converting from canvas to screen coordinates. 
> +        Fixed by inverting the rectangle in Y, and changing
> +        SharedGraphicsContext3D::scissor to take glScissor-like parameters.

need a link to the bug in the ChangeLog

[Stephen White]

Created attachment 82525 [details]
Patch

[James Robinson]

Comment on attachment 82525 [details]
Patch

R=me but please see if there's anything in test_expectations.txt that can ensure this change is covered by our bots.

[Stephen White]

(In reply to comment #5)
> (From update of attachment 82525 [details])
> R=me but please see if there's anything in test_expectations.txt that can ensure this change is covered by our bots.

Yes, fast/canvas/canvas-strokeRect.html covers it.  I'll add that to the CL.

[James Robinson]

(In reply to comment #6)
> (In reply to comment #5)
> > (From update of attachment 82525 [details] [details])
> > R=me but please see if there's anything in test_expectations.txt that can ensure this change is covered by our bots.
> 
> Yes, fast/canvas/canvas-strokeRect.html covers it.  I'll add that to the CL.

Are we running that test right now and failing it, is it marked as an expected failure, or do we not run this test in any configuration that would catch this failure?

[Stephen White]

(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #5)
> > > (From update of attachment 82525 [details] [details] [details])
> > > R=me but please see if there's anything in test_expectations.txt that can ensure this change is covered by our bots.
> > 
> > Yes, fast/canvas/canvas-strokeRect.html covers it.  I'll add that to the CL.
> 
> Are we running that test right now and failing it, is it marked as an expected failure, or do we not run this test in any configuration that would catch this failure?

Yes, we're running it now, and it's marked as an expected failure (GPU only).  That's how I found this bug.  :)

[Stephen White]

Created attachment 82532 [details]
Patch

[James Robinson]

Comment on attachment 82532 [details]
Patch

Sweet!

[Stephen White]

Committed r78625: <http://trac.webkit.org/changeset/78625>