Bug 54482 – Moved MarkedBlock data members to the head of the block

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Geoffrey Garen]

Moved MarkedBlock data members to the head of the block

[Geoffrey Garen]

Created attachment 82498 [details]
Patch

[WebKit Review Bot]

Attachment 82498 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/runtime/MarkedBlock.h:53:  BLOCK_MASK is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/JavaScriptCore/runtime/MarkedBlock.h:64:  CELLS_PER_BLOCK is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

Comment on attachment 82498 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82498&action=review

Change seems fine. Could you please take a little time out and make the constants use normal style instead of MACRO_STYLE? Then the style bot would like you better.

> Source/JavaScriptCore/runtime/MarkedBlock.h:38
> +    template <size_t divisor> inline size_t roundUpToMultipleOf(size_t x)

Normally we don’t put a space between template and the "<" by analogy with the function name and "(".

[Geoffrey Garen]

> Could you please take a little time out and make the constants use normal style instead of MACRO_STYLE? Then the style bot would like you better.

OK, I'll do that in my next patch.

[Geoffrey Garen]

Committed r78605: <http://trac.webkit.org/changeset/78605>