Bug 54465 – CSS selectors are applied to SVG shadow trees

• Status: RESOLVED
• Resolution: WONTFIX
• Component: SVG

[Antti Koivisto]

This

CSSStyleSelector::SelectorMatch CSSStyleSelector::SelectorChecker::checkSelector(CSSSelector* sel, Element* e, HashSet<AtomicStringImpl*>* selectorAttrs, PseudoId& dynamicPseudo, bool isSubSelector, bool encounteredLink, RenderStyle* elementStyle, RenderStyle* elementParentStyle) const
{
#if ENABLE(SVG)
    // Spec: CSS2 selectors cannot be applied to the (conceptually) cloned DOM tree
    // because its contents are not part of the formal document structure.
    if (e->isSVGElement() && e->isShadowRoot())
        return SelectorFailsCompletely;
#endif

won't achieve what the comment claims. If the match succeed without reaching the root the selector will still get applied. We should not be running selector matching in the shadow tree at all.

[Antti Koivisto]

If this is fixed we can use selector fast path also for SVG (https://bugs.webkit.org/show_bug.cgi?id=54460)

[Dirk Schulze]

These lines don't seem to exist anymore.