Bug 54464 – Rename Color::name() to Color::nameForRenderTreeAsText()

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Andreas Kling]

Color::name() returns the color as either #RRGGBB or #RRGGBBAA.
Since the latter is not a valid CSS color, it can't be re-parsed by WebKit, and should only be used in DRT dumps.

Existing call sites that wrongly use drtName() will be updated separately with accompanying layout tests.

[Andreas Kling]

Created attachment 82460 [details]
Proposed patch

drtName us quite cryptic, and the function is not called by DumpRenderTree anyway. How about nameForRenderTreeAsText(), externalRepresentation(), or nameForExternalRepresentation()?

[Andreas Kling]

(In reply to comment #2)
> drtName us quite cryptic, and the function is not called by DumpRenderTree anyway. How about nameForRenderTreeAsText(), externalRepresentation(), or nameForExternalRepresentation()?

I'm not fussed about the name- nameForRenderTreeAsText() sounds fine to me.

[Darin Adler]

Comment on attachment 82460 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82460&action=review

Please use a better name, though!

> Source/WebCore/platform/graphics/Color.h:101
> +    // Returns the color serialized as either #RRGGBB or #RRGGBBAA
> +    // The latter format is not a valid CSS color, and should only be seen in DRT dumps.
> +    String drtName() const;

I suggest nameForDumpRenderTree or nameForRenderTreeDumps, or nameForRegressionTestDumps or nameForLayoutTests or something along those lines. Not a big fan of acronyms, and they are even worse as all lowercase prefixes!

[Darin Adler]

(In reply to comment #3)
> (In reply to comment #2)
> > drtName us quite cryptic, and the function is not called by DumpRenderTree anyway. How about nameForRenderTreeAsText(), externalRepresentation(), or nameForExternalRepresentation()?
> 
> I'm not fussed about the name- nameForRenderTreeAsText() sounds fine to me.

I like that one too. Mitz’s names are all better than mine. I didn’t see Mitz’s comments before I posted mine.

[Andreas Kling]

Committed r78590: <http://trac.webkit.org/changeset/78590>