Patch to follow.
Created attachment 82457 [details] Patch
Comment on attachment 82457 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82457&action=review > LayoutTests/http/tests/inspector/elements-test.js:164 > + if (children.length) This will fail if children is undefined. Prefer early return when children is undefined above. r- for this. > LayoutTests/http/tests/inspector/inspector-test.js:142 > + if (/^test/.exec(symbol) && typeof testSuite[symbol] === "function") test() should be used instead of exec() here. > LayoutTests/http/tests/inspector/inspector-test.js:153 > + testSuiteTests.splice(0, 1); Just use Array.shift() instead of these two lines. > LayoutTests/inspector/elements/insert-node-collapsed.html:23 > + function callback(node) You shouldn't rely on the order of the properties in for/in loop. If you need the tests to be executed in a particular order you should use array instead of object. > LayoutTests/inspector/elements/mutate-unknown-node.html:31 > + InspectorTest.addResult("DOMAgent event fired. Should only happen once for output node: " + type + " " + event.target.nodeName + "#" + event.target.getAttribute("id")); Please, move description of correct result to the static section below in the body.
(In reply to comment #2) > (From update of attachment 82457 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=82457&action=review > > > LayoutTests/http/tests/inspector/elements-test.js:164 > > + if (children.length) > > This will fail if children is undefined. Prefer early return when children is undefined above. r- for this. > Done. > > LayoutTests/http/tests/inspector/inspector-test.js:142 > > + if (/^test/.exec(symbol) && typeof testSuite[symbol] === "function") > > test() should be used instead of exec() here. > Done. > > LayoutTests/http/tests/inspector/inspector-test.js:153 > > + testSuiteTests.splice(0, 1); > > Just use Array.shift() instead of these two lines. > Done. > > LayoutTests/inspector/elements/insert-node-collapsed.html:23 > > + function callback(node) > > You shouldn't rely on the order of the properties in for/in loop. If you need the tests to be executed in a particular order you should use array instead of object. > This is a de-facto standard tested in many javascript layout tests. > > LayoutTests/inspector/elements/mutate-unknown-node.html:31 > > + InspectorTest.addResult("DOMAgent event fired. Should only happen once for output node: " + type + " " + event.target.nodeName + "#" + event.target.getAttribute("id")); > > Please, move description of correct result to the static section below in the body. I think it reflects what is happening now better this way.
Created attachment 82465 [details] Patch
Committed r78576: <http://trac.webkit.org/changeset/78576>
http://trac.webkit.org/changeset/78576 might have broken Qt Linux Release The following tests are not passing: inspector/elements/mutate-unknown-node.html