Bug 54447 - [chromium] add WebIDBFactory::deleteDatabase method
Summary: [chromium] add WebIDBFactory::deleteDatabase method
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-15 04:34 PST by jochen
Modified: 2011-02-15 13:09 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.72 KB, patch)
2011-02-15 04:35 PST, jochen
no flags Details | Formatted Diff | Diff
Patch (1.75 KB, patch)
2011-02-15 04:48 PST, jochen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2011-02-15 04:34:57 PST
[chromium] add WebIDBFactory::deleteDatabase method
Comment 1 jochen 2011-02-15 04:35:33 PST
Created attachment 82436 [details]
Patch
Comment 2 Hans Wennborg 2011-02-15 04:41:48 PST
Comment on attachment 82436 [details]
Patch

lgtm

View in context: https://bugs.webkit.org/attachment.cgi?id=82436&action=review

> Source/WebKit/chromium/public/WebIDBFactory.h:57
>          WEBKIT_ASSERT_NOT_REACHED();

maybe move this up to keep it all on one line, while you're fixing the style anyway?
Comment 3 jochen 2011-02-15 04:48:58 PST
Created attachment 82437 [details]
Patch
Comment 4 Jeremy Orlow 2011-02-15 10:44:23 PST
Comment on attachment 82437 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2011-02-15 13:09:25 PST
Comment on attachment 82437 [details]
Patch

Clearing flags on attachment: 82437

Committed r78606: <http://trac.webkit.org/changeset/78606>
Comment 6 WebKit Commit Bot 2011-02-15 13:09:30 PST
All reviewed patches have been landed.  Closing bug.