Bug 54437 - Web Inspector: move rest of the tests off old harness.
Summary: Web Inspector: move rest of the tests off old harness.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-14 23:02 PST by Pavel Feldman
Modified: 2011-02-15 02:51 PST (History)
13 users (show)

See Also:


Attachments
Patch (161.92 KB, patch)
2011-02-14 23:47 PST, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-02-14 23:02:30 PST
All tests migrated.
Comment 1 Pavel Feldman 2011-02-14 23:47:34 PST
Created attachment 82422 [details]
Patch
Comment 2 Yury Semikhatsky 2011-02-15 01:38:19 PST
Comment on attachment 82422 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82422&action=review

> LayoutTests/http/tests/inspector-enabled/console-log-before-frame-navigation.html:13
> +window.addEventListener("message", receiveMessage, false);

What's the reason for moving this line?

> LayoutTests/http/tests/inspector/resources/extension-main.html:5
> +function dumpObject(object, nondeterministicProps, prefix, firstLinePrefix)

Why not use InspectorTest.addObject instead of this custom function?
Comment 3 Pavel Feldman 2011-02-15 02:02:41 PST
(In reply to comment #2)
> (From update of attachment 82422 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=82422&action=review
> 
> > LayoutTests/http/tests/inspector-enabled/console-log-before-frame-navigation.html:13
> > +window.addEventListener("message", receiveMessage, false);
> 
> What's the reason for moving this line?
> 
> > LayoutTests/http/tests/inspector/resources/extension-main.html:5
> > +function dumpObject(object, nondeterministicProps, prefix, firstLinePrefix)
> 
> Why not use InspectorTest.addObject instead of this custom function?

These are injected into extension bodies where InspectorTest object is not exposed.

Committed r78535
Comment 4 WebKit Review Bot 2011-02-15 02:51:12 PST
http://trac.webkit.org/changeset/78535 might have broken Qt Linux Release