RESOLVED FIXED 54437
Web Inspector: move rest of the tests off old harness. 
https://bugs.webkit.org/show_bug.cgi?id=54437
Summary Web Inspector: move rest of the tests off old harness.
Pavel Feldman
Reported 2011-02-14 23:02:30 PST
All tests migrated.
Attachments
Patch (161.92 KB, patch)
2011-02-14 23:47 PST, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-02-14 23:47:34 PST
Created attachment 82422 [details] Patch
Yury Semikhatsky
Comment 2 2011-02-15 01:38:19 PST
Comment on attachment 82422 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82422&action=review > LayoutTests/http/tests/inspector-enabled/console-log-before-frame-navigation.html:13 > +window.addEventListener("message", receiveMessage, false); What's the reason for moving this line? > LayoutTests/http/tests/inspector/resources/extension-main.html:5 > +function dumpObject(object, nondeterministicProps, prefix, firstLinePrefix) Why not use InspectorTest.addObject instead of this custom function?
Pavel Feldman
Comment 3 2011-02-15 02:02:41 PST
(In reply to comment #2) > (From update of attachment 82422 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=82422&action=review > > > LayoutTests/http/tests/inspector-enabled/console-log-before-frame-navigation.html:13 > > +window.addEventListener("message", receiveMessage, false); > > What's the reason for moving this line? > > > LayoutTests/http/tests/inspector/resources/extension-main.html:5 > > +function dumpObject(object, nondeterministicProps, prefix, firstLinePrefix) > > Why not use InspectorTest.addObject instead of this custom function? These are injected into extension bodies where InspectorTest object is not exposed. Committed r78535
WebKit Review Bot
Comment 4 2011-02-15 02:51:12 PST
http://trac.webkit.org/changeset/78535 might have broken Qt Linux Release
Note You need to log in before you can comment on or make changes to this bug.