Bug 54433 - allow for modifying comments without the mouse
Summary: allow for modifying comments without the mouse
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-14 21:23 PST by Ojan Vafai
Modified: 2011-02-14 21:54 PST (History)
1 user (show)

See Also:


Attachments
Patch (7.81 KB, patch)
2011-02-14 21:44 PST, Ojan Vafai
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2011-02-14 21:23:47 PST
allow for modifying comments without the mouse
Comment 1 Ojan Vafai 2011-02-14 21:44:07 PST
Created attachment 82413 [details]
Patch
Comment 2 Adam Barth 2011-02-14 21:48:42 PST
Comment on attachment 82413 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82413&action=review

> Websites/bugs.webkit.org/code-review.js:1291
> +    $(unfrozen_comment).find('textarea')[0].focus();

Is this $ needed?
Comment 3 Ojan Vafai 2011-02-14 21:52:40 PST
Comment on attachment 82413 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82413&action=review

>> Websites/bugs.webkit.org/code-review.js:1291
>> +    $(unfrozen_comment).find('textarea')[0].focus();
> 
> Is this $ needed?

Whoops. no.
Comment 4 Ojan Vafai 2011-02-14 21:54:06 PST
Committed r78531: <http://trac.webkit.org/changeset/78531>