RESOLVED FIXED 54430
improve line selection in the code review tool
https://bugs.webkit.org/show_bug.cgi?id=54430
Summary improve line selection in the code review tool
Ojan Vafai
Reported 2011-02-14 20:28:01 PST
improve line selection in the code review tool
Attachments
Patch (5.99 KB, patch)
2011-02-14 20:29 PST, Ojan Vafai
abarth: review+
Ojan Vafai
Comment 1 2011-02-14 20:29:38 PST
Adam Barth
Comment 2 2011-02-14 20:44:20 PST
Comment on attachment 82411 [details] Patch You said you'd written you last patch!
Ojan Vafai
Comment 3 2011-02-14 21:47:02 PST
Antonio Gomes
Comment 4 2011-02-17 06:06:02 PST
Btw, line selection is broken in Firefox 4 beta 11. Console output: Error: event is not defined Source File: https://bugs.webkit.org/code-review.js?version=35 Line: 1512 Not sure if it is a regression from this bug, but it used to work fine.
Ojan Vafai
Comment 5 2011-02-17 17:45:36 PST
(In reply to comment #4) > Btw, line selection is broken in Firefox 4 beta 11. Console output: > > Error: event is not defined > Source File: https://bugs.webkit.org/code-review.js?version=35 > Line: 1512 > > Not sure if it is a regression from this bug, but it used to work fine. Yup. It's a regression from this patch. Fix coming soon. I moved a line up so we're now getting a JS error at the beginning of the mousedown handler instead of at the end of it. :)
Ojan Vafai
Comment 6 2011-02-17 18:14:25 PST
Note You need to log in before you can comment on or make changes to this bug.