Bug 54430 - improve line selection in the code review tool
Summary: improve line selection in the code review tool
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-14 20:28 PST by Ojan Vafai
Modified: 2011-02-17 18:14 PST (History)
2 users (show)

See Also:


Attachments
Patch (5.99 KB, patch)
2011-02-14 20:29 PST, Ojan Vafai
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2011-02-14 20:28:01 PST
improve line selection in the code review tool
Comment 1 Ojan Vafai 2011-02-14 20:29:38 PST
Created attachment 82411 [details]
Patch
Comment 2 Adam Barth 2011-02-14 20:44:20 PST
Comment on attachment 82411 [details]
Patch

You said you'd written you last patch!
Comment 3 Ojan Vafai 2011-02-14 21:47:02 PST
Committed r78530: <http://trac.webkit.org/changeset/78530>
Comment 4 Antonio Gomes 2011-02-17 06:06:02 PST
Btw, line selection is broken in Firefox 4 beta 11. Console output:

Error: event is not defined
Source File: https://bugs.webkit.org/code-review.js?version=35
Line: 1512

Not sure if it is a regression from this bug, but it used to work fine.
Comment 5 Ojan Vafai 2011-02-17 17:45:36 PST
(In reply to comment #4)
> Btw, line selection is broken in Firefox 4 beta 11. Console output:
> 
> Error: event is not defined
> Source File: https://bugs.webkit.org/code-review.js?version=35
> Line: 1512
> 
> Not sure if it is a regression from this bug, but it used to work fine.

Yup. It's a regression from this patch. Fix coming soon. I moved a line up so we're now getting a JS error at the beginning of the mousedown handler instead of at the end of it. :)
Comment 6 Ojan Vafai 2011-02-17 18:14:25 PST
bug 54702