improve line selection in the code review tool
Created attachment 82411 [details] Patch
Comment on attachment 82411 [details] Patch You said you'd written you last patch!
Committed r78530: <http://trac.webkit.org/changeset/78530>
Btw, line selection is broken in Firefox 4 beta 11. Console output: Error: event is not defined Source File: https://bugs.webkit.org/code-review.js?version=35 Line: 1512 Not sure if it is a regression from this bug, but it used to work fine.
(In reply to comment #4) > Btw, line selection is broken in Firefox 4 beta 11. Console output: > > Error: event is not defined > Source File: https://bugs.webkit.org/code-review.js?version=35 > Line: 1512 > > Not sure if it is a regression from this bug, but it used to work fine. Yup. It's a regression from this patch. Fix coming soon. I moved a line up so we're now getting a JS error at the beginning of the mousedown handler instead of at the end of it. :)
bug 54702