Bug 54418 – r78499 causes assertion failure in http/tests/xmlhttprequest/cache-override.html

• Status: RESOLVED
• Resolution: FIXED
• Component: Text

[Peter Kasting]

Chromium bots started crashing on this test after r78499 went in (see our test dashboard at http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&group=%40ToT%20-%20chromium.org&tests=http%2Ftests%2Fxmlhttprequest%2Fcache-override.html ).

The critical bit is this chunk I copied from the Linux run:

ASSERTION FAILED: count > m_partialSequenceSize
third_party/WebKit/Source/WebCore/platform/text/TextCodecUTF8.cpp(217) : virtual WTF::String WebCore::TextCodecUTF8::decode(const char*, size_t, bool, bool, bool&)
[14203:14203:2241232273962:ERROR:process_util_posix.cc(106)] Received signal 11

[Mario Sanchez Prada]

It's also causing crashes in SnowLeopard and GTK bots.

See full backtrace as got from the GTK 32-bit debug bot in my last comment in bug 53898:
https://bugs.webkit.org/show_bug.cgi?id=53898#c56

[Antti Koivisto]

Created attachment 82431 [details]
check for zero

[Andreas Kling]

Comment on attachment 82431 [details]
check for zero

r=me

[Antti Koivisto]

Comment on attachment 82431 [details]
check for zero

Hmm, no this is not correct. It should still flush the partial sequence and set the error flag. Better leave it for Darin.

[Andreas Kling]

Comment on attachment 82431 [details]
check for zero

re-r+ing again as agreed on IRC.
I don't see a problem with this patch, TextCodecUTF16 has the same check.

[Antti Koivisto]

http://trac.webkit.org/changeset/78541

I also filed

https://bugs.webkit.org/show_bug.cgi?id=54444
Correct handling of end of buffer partial sequence in UFT8 decoder when flushing with zero length

[Peter Kasting]

(For clarity, the patch here landed in r78541)