Bug 54414 - [GTK] testwebdatasource test fails in the bots
Summary: [GTK] testwebdatasource test fails in the bots
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 54731 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-02-14 14:51 PST by Alejandro G. Castro
Modified: 2011-02-19 11:02 PST (History)
1 user (show)

See Also:


Attachments
Proposed patch (2.87 KB, patch)
2011-02-14 15:04 PST, Alejandro G. Castro
xan.lopez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alejandro G. Castro 2011-02-14 14:51:44 PST
Apparently the uri we get from soup_message_get_uri is not the same we pass to the load uri API:

ERROR:../../Source/WebKit/gtk/tests/testwebdatasource.c:95:notify_load_status_cb: assertion failed (webkit_network_request_get_uri(request) == "http://webkit.org/"): ("http://www.webkit.org/" == "http://webkit.org/")

It gets the uri the server returns when loading. It works just when the loading process fails (cancelled in this case) because the assertion is not checked, it fails randomly, probably depending on the time the site takes to answer and if it comes before or after the timeout.
Comment 1 Alejandro G. Castro 2011-02-14 15:04:21 PST
Created attachment 82368 [details]
Proposed patch
Comment 2 Xan Lopez 2011-02-14 15:08:18 PST
Comment on attachment 82368 [details]
Proposed patch

Hum, I guess that's OK :)
Comment 3 Alejandro G. Castro 2011-02-14 15:52:21 PST
Landed http://trac.webkit.org/changeset/78519
Comment 4 Martin Robinson 2011-02-19 11:02:23 PST
*** Bug 54731 has been marked as a duplicate of this bug. ***