Bug 54405 – Fix coverity REVERSE_INULL errors

• Status: RESOLVED
• Resolution: INVALID
• Component: WebCore Misc.

Created attachment 82346 [details]
Patch fixing all the reverse_inull errors in coverity

I am submitting a patch which fixes all the reverse_inull errors from coverity.

[Suresh Voruganti]

Updated Platform version to reflect Symbian and adding to Qtwebkit 2.1.1 Nice to have master bug

Created attachment 82490 [details]
patch fixing the coverity reverse_inull errors in webkit.org

Created attachment 82491 [details]
Changelog

[WebKit Review Bot]

Attachment 82491 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files']" exit_code: 1

Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Attachment 82490 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/dom/ContainerNode.cpp', u'S..." exit_code: 1

Source/WebCore/dom/ContainerNode.cpp:791:  Missing space before ( in if(  [whitespace/parens] [5]
Source/WebCore/dom/ContainerNode.cpp:856:  Missing space before ( in if(  [whitespace/parens] [5]
Source/WebCore/page/Chrome.cpp:400:  Missing space before ( in if(  [whitespace/parens] [5]
Source/WebCore/page/Chrome.cpp:400:  Missing space before {  [whitespace/braces] [5]
Source/WebCore/page/Chrome.cpp:413:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/page/Chrome.cpp:552:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 6 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

Comment on attachment 82490 [details]
patch fixing the coverity reverse_inull errors in webkit.org 

Style is wrong here.

And we won’t just add null checks without test cases. We want to cover the cases where these are null, not just take the tool’s word for it. The tool helped us discover the missing null checks. Now human beings have to actually create test cases.

Also, patches need to include the change log entries in them. Separately posting a copy of the entire change log is not acceptable.

[Darin Adler]

Comment on attachment 82491 [details]
Changelog 

Not a patch, can’t be reviewed.

[Alexis Menard (darktears)]

Please follow the wiki for contributing patches :

http://www.webkit.org/coding/contributing.html

Thanks

This bug can be ignored because reverse_inull errors cannot be proven through appropriate test cases.