RESOLVED FIXED Bug 54403
Should turn off frame pointer omission (FPO) for Release (not Production) builds 
https://bugs.webkit.org/show_bug.cgi?id=54403
Summary Should turn off frame pointer omission (FPO) for Release (not Production) builds
Adam Roben (:aroben)
Reported 2011-02-14 11:28:13 PST
Should turn off frame pointer omission (FPO) for Release (not Release_LTCG) builds. This would make it easier to profile developer Release builds, while not harming customer builds (which use Release_LTCG).
Attachments
Patch (1.14 KB, patch)
2011-03-30 15:58 PDT, Steve Falkenburg 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2011-02-14 11:28:48 PST
Some people think FPO isn't really worth it, even for customer builds: <http://blogs.msdn.com/b/yvesdolc/archive/2009/09/15/consider-not-using-the-frame-pointer-optimization-when-building-your-software.aspx>. Apparently Microsoft isn't using it for its own software anymore.
Adam Roben (:aroben)
Comment 2 2011-02-14 11:29:25 PST
It would be interesting to run some benchmarks with FPO on and off to see if it's even helping us appreciably.
Adam Roben (:aroben)
Comment 3 2011-02-23 08:51:19 PST
(In reply to comment #2) > It would be interesting to run some benchmarks with FPO on and off to see if it's even helping us appreciably. I filed bug 55051 to cover this aspect.
Adam Roben (:aroben)
Comment 4 2011-02-23 08:51:40 PST
I don't think we need to run benchmarks before turning off FPO for the Release configuration.
Adam Roben (:aroben)
Comment 5 2011-02-23 09:05:35 PST
<rdar://problem/9042187>
Steve Falkenburg
Comment 6 2011-03-30 15:58:19 PDT
Created attachment 87633 [details] Patch
Adam Roben (:aroben)
Comment 7 2011-03-30 15:59:02 PDT
Comment on attachment 87633 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87633&action=review > WebKitLibraries/win/tools/vsprops/release.vsprops:10 > + AdditionalOptions="/Oy-" > + OmitFramePointers="false" I think you should add a comment in the ChangeLog about why both of these are being set.
Adam Roben (:aroben)
Comment 8 2011-03-30 16:01:21 PDT
*** Bug 57510 has been marked as a duplicate of this bug. ***
Steve Falkenburg
Comment 9 2011-03-30 16:04:52 PDT
http://trac.webkit.org/changeset/82515
Note You need to log in before you can comment on or make changes to this bug.