Bug 54400 - Need WebKit API to determine whether we have a site icon for a given URL
Summary: Need WebKit API to determine whether we have a site icon for a given URL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Brian Weinstein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-14 10:15 PST by Brian Weinstein
Modified: 2011-02-14 15:20 PST (History)
5 users (show)

See Also:


Attachments
[PATCH] Fix (3.70 KB, patch)
2011-02-14 10:24 PST, Brian Weinstein
beidson: review+
beidson: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Weinstein 2011-02-14 10:15:26 PST
We need WebKit API to determine whether we have a site icon for a given URL.

This will return true if we do, false if we will use the default icon.
Comment 1 Brian Weinstein 2011-02-14 10:24:47 PST
Created attachment 82331 [details]
[PATCH] Fix
Comment 2 Brady Eidson 2011-02-14 11:20:07 PST
Comment on attachment 82331 [details]
[PATCH] Fix

Can you add a space to the current newline instead of adding a new newline?
Comment 3 Brian Weinstein 2011-02-14 11:28:04 PST
(In reply to comment #2)
> (From update of attachment 82331 [details])
> Can you add a space to the current newline instead of adding a new newline?

The file already had an extra newline, so I was able to delete it instead of adding a new one.

Thanks for the review!
Comment 4 WebKit Review Bot 2011-02-14 14:57:59 PST
http://trac.webkit.org/changeset/78498 might have broken GTK Linux 64-bit Debug
Comment 5 Brian Weinstein 2011-02-14 15:20:47 PST
Landed in r78498.