RESOLVED FIXED 54397
Web Inspector: Support external CSS stylesheet freeflow text editing 
https://bugs.webkit.org/show_bug.cgi?id=54397
Summary Web Inspector: Support external CSS stylesheet freeflow text editing
Alexander Pavlov (apavlov)
Reported 2011-02-14 09:28:43 PST
Users ask for an ability to edit the external CSS textual content (rather than structured rules).
Attachments
[PATCH] Preliminary solution (8.26 KB, patch)
2011-03-11 10:23 PST, Alexander Pavlov (apavlov) 		no flags
DetailsFormatted DiffDiff
[PATCH] Suggested complete solution (5.83 KB, patch)
2011-03-29 09:15 PDT, Alexander Pavlov (apavlov) 		yurys: review-
DetailsFormatted DiffDiff
[PATCH] Comment addressed (6.94 KB, patch)
2011-03-29 10:01 PDT, Alexander Pavlov (apavlov) 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alexander Pavlov (apavlov)
Comment 1 2011-03-11 10:23:26 PST
Created attachment 85489 [details] [PATCH] Preliminary solution
Alexander Pavlov (apavlov)
Comment 2 2011-03-29 09:15:54 PDT
Created attachment 87343 [details] [PATCH] Suggested complete solution
Yury Semikhatsky
Comment 3 2011-03-29 09:49:02 PDT
Comment on attachment 87343 [details] [PATCH] Suggested complete solution View in context: https://bugs.webkit.org/attachment.cgi?id=87343&action=review > Source/WebCore/inspector/front-end/ResourceView.js:148 > + canEditScriptSource: function() Please move this methods into a CSS-specific SourceFrameDelegate, otherwise looks good.
Alexander Pavlov (apavlov)
Comment 4 2011-03-29 10:01:06 PDT
Created attachment 87352 [details] [PATCH] Comment addressed
Yury Semikhatsky
Comment 5 2011-03-29 10:04:14 PDT
Comment on attachment 87352 [details] [PATCH] Comment addressed View in context: https://bugs.webkit.org/attachment.cgi?id=87352&action=review > Source/WebCore/inspector/front-end/ResourceView.js:172 > + this.styleSheet = styleSheet; styleSheet should be private, please fix before landing.
Alexander Pavlov (apavlov)
Comment 6 2011-03-29 10:36:27 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebCore/ChangeLog M Source/WebCore/inspector/front-end/ResourceView.js M Source/WebCore/inspector/front-end/ResourcesPanel.js M Source/WebCore/inspector/front-end/SourceFrame.js Committed r82274
WebKit Review Bot
Comment 7 2011-03-29 11:01:16 PDT
http://trac.webkit.org/changeset/82274 might have broken Leopard Intel Debug (Tests)
Note You need to log in before you can comment on or make changes to this bug.