Bug 54394 – [GTK] Bump GTK+3 dependency to 3.0

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Garcia Campos]

Now that GTK+ has been released we should bump the dependency to 3.0. Maybe we should make it the default option now, falling back to gtk+2 when gtk+3 is not present.

[Carlos Garcia Campos]

Created attachment 82318 [details]
Patch

[Martin Robinson]

This seems reasonable. I'd like to get Xan or Gustavo's approval as well though.

[Xan Lopez]

I think making the dependency reflect the minimum version we actually need to compile makes sense, so I don't see any reason to do this.

[Carlos Garcia Campos]

(In reply to comment #3)
> I think making the dependency reflect the minimum version we actually need to compile makes sense, so I don't see any reason to do this.

Library name has changed, you won't be using gtk+ 3.0.x unless you bump the dependency to 3.0, I don't think we want to use 2.99.x.

[Xan Lopez]

(In reply to comment #4)
> Library name has changed, you won't be using gtk+ 3.0.x unless you bump the dependency to 3.0, I don't think we want to use 2.99.x.

I didn't know they had changed them *again* for 3.0. You should have mentioned it in the bug report, neither me or Martin were aware of this. r=me then.

[Carlos Garcia Campos]

Committed r79150: <http://trac.webkit.org/changeset/79150>

[Carlos Garcia Campos]

(In reply to comment #5)
> (In reply to comment #4)
> > Library name has changed, you won't be using gtk+ 3.0.x unless you bump the dependency to 3.0, I don't think we want to use 2.99.x.
> 
> I didn't know they had changed them *again* for 3.0. You should have mentioned it in the bug report, neither me or Martin were aware of this. r=me then.

Ok, sorry, I thought that depending on an stable version was enough reason to bump requirements. Pushed now.