Bug 54391 - Missing parameter from the dynamic update of FESpecularLighting filter
Summary: Missing parameter from the dynamic update of FESpecularLighting filter
Status: RESOLVED DUPLICATE of bug 56906
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Renata Hodovan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-14 06:50 PST by Renata Hodovan
Modified: 2011-03-30 08:45 PDT (History)
1 user (show)

See Also:

Attachments
Patch (156.77 KB, patch)
2011-02-14 06:59 PST, Renata Hodovan 		krit: review-
Details | Formatted Diff | Diff
Patch (152.19 KB, patch)
2011-02-15 00:54 PST, Renata Hodovan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Renata Hodovan 2011-02-14 06:50:51 PST 
Missing parameter from the dynamic update of FESpecularLighting filter
Comment 1 Renata Hodovan 2011-02-14 06:59:21 PST 
Created attachment 82314 [details]
Patch
Comment 2 Dirk Schulze 2011-02-14 08:36:52 PST 
Comment on attachment 82314 [details]
Patch

I'm unsure about lightning-color. This is a CSS property and should be be handled via SVGStyledElement, RenderStyle and the Renderer of primitives. Also you checked in a reference image with fail messages. Guess this is not expected.
Comment 3 Renata Hodovan 2011-02-15 00:48:31 PST 
(In reply to comment #2)
> (From update of attachment 82314 [details])
> Also you checked in a reference image with fail messages. Guess this is not expected.
Yes, you are right. My mistake. :$

> I'm unsure about lightning-color. This is a CSS property and should be be handled via SVGStyledElement, RenderStyle and the Renderer of primitives. 
I don't know, but FEDiffuseLighting handles the update of lighting-color the same way.
Comment 4 Nikolas Zimmermann 2011-02-15 00:54:05 PST 
(In reply to comment #2)
> (From update of attachment 82314 [details])
> I'm unsure about lightning-color. This is a CSS property and should be be handled via SVGStyledElement, RenderStyle and the Renderer of primitives. Also you checked in a reference image with fail messages. Guess this is not expected.

There is also a SVG _attribute_ "lighting-color", despite the CSS property, I think handling the attr update this way is just fine, no? Or is your concern that "lighting-color" attribute should be mapped to a CSS property, and thus updates should be handled differently?

Reni, can you check wheter the lighting-color attribute is properly mapped to it's corresponding CSS attribute? (Are changes to the attribute value, immediately visible in the computed style, even _without_ your patch?)
Comment 5 Renata Hodovan 2011-02-15 00:54:14 PST 
Created attachment 82426 [details]
Patch
Comment 6 Nikolas Zimmermann 2011-02-15 00:59:42 PST 
Dirk is right, SVGStyledElement properly maps diffuse_lightingAttr to it's corresponding CSS property (mapToEntry & friends).
That means that the RenderSVGResourceFilterPrimitive (the renderer created for SVGFEDiffuseLighting/SVGFESpecLighting) should receive styleDidChange/styleWillChange calls, where you can catch those style changes.
Comment 7 Renata Hodovan 2011-03-30 08:45:30 PDT 
The dynamic update of CSS related SVG props are handled in #56906.

*** This bug has been marked as a duplicate of bug 56906 ***