Bug 54390 - Web Inspector: move timeline and highlighter tests to the new harness.
Summary: Web Inspector: move timeline and highlighter tests to the new harness.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 54442
Blocks:
  Show dependency treegraph
 
Reported: 2011-02-14 06:35 PST by Pavel Feldman
Modified: 2011-02-15 02:07 PST (History)
13 users (show)

See Also:


Attachments
Patch (54.51 KB, patch)
2011-02-14 06:44 PST, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-02-14 06:35:55 PST
Patch to follow.
Comment 1 Pavel Feldman 2011-02-14 06:44:56 PST
Created attachment 82312 [details]
Patch
Comment 2 Yury Semikhatsky 2011-02-14 07:04:21 PST
Comment on attachment 82312 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82312&action=review

> LayoutTests/inspector/timeline-script-tag-2.js:-1
> -console.markTimeline("SCRIPT TAG");

I don't see the call to markTimeline anymore, is it intentional?
Comment 3 Yury Semikhatsky 2011-02-14 07:32:43 PST
Comment on attachment 82312 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82312&action=review

> LayoutTests/inspector/resources/timeline-iframe-data.html:8
> +    console.log("iframe loaded");

Please file a bug about sending messages from the inspected page to the front-end.
Comment 4 Pavel Feldman 2011-02-14 07:37:05 PST
Comment on attachment 82312 [details]
Patch

It is intentional.
Comment 5 Pavel Feldman 2011-02-14 07:44:11 PST
Committed r78477: <http://trac.webkit.org/changeset/78477>
Comment 6 WebKit Review Bot 2011-02-14 08:39:22 PST
http://trac.webkit.org/changeset/78477 might have broken Qt Linux Release
The following tests are not passing:
inspector/timeline-network-resource.html
inspector/timeline-script-tag-1.html