Bug 54379 – Add basic parser for Content Security Policy

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adam Barth]

Add basic parser for Content Security Policy

[Adam Barth]

Created attachment 82296 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 82296 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82296&action=review

LGTM. I look forward to seeing this testable in the next patch. :)

> Source/WebCore/page/ContentSecurityPolicy.cpp:117
> +            m_directives.append(CSPDirective(String(name), String(value)));

You should explain why you use this method for creating strings, since you say it does only 2 mallocs instead of 4.  Seems like a useful comment.

[Adam Barth]

Created attachment 82297 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 82297 [details]
Patch for landing

Rejecting attachment 82297 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'apply-..." exit_code: 1

Last 500 characters of output:
rks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", line 361, in _call_chain
    result = func(*args)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_http.py", line 756, in https_open
    return self.do_open(conn_factory, req)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_http.py", line 706, in do_open
    raise URLError(err)
urllib2.URLError: <urlopen error [Errno 60] Operation timed out>

Full output: http://queues.webkit.org/results/7913501

[Eric Seidel (no email)]

Comment on attachment 82297 [details]
Patch for landing

We should probably catch and ignore URLError in certain cases.

[WebKit Commit Bot]

Comment on attachment 82297 [details]
Patch for landing

Clearing flags on attachment: 82297

Committed r78497: <http://trac.webkit.org/changeset/78497>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.