[Chromium] Fix wrong popup position for RTL(again)
Created attachment 82288 [details] Patch
Could you review again? As I wrote ChangeLog, the bug is introduced by previous RTL fix and not good for the fix http://codereview.chromium.org/6024008/.
Comment on attachment 82288 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82288&action=review > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) Please remove this line. > Source/WebCore/ChangeLog:15 > + (WebCore::PopupContainer::layoutAndCalculateWidgetRect): Change the input parameter to take |popupInitialCoordinate| again. And calculate correct right position with returned right offset from layoutAndRightOffset(). We don't use the || notation in WebKit. Please remove it. > Source/WebCore/ChangeLog:17 > + (WebCore::PopupContainer::layoutAndRightOffset): Change the name from layout() and to return |rightOffset| value. ditto. > Source/WebCore/platform/chromium/PopupMenuChromium.cpp:351 > + // Use |popupInitialCoordinate.x()| + |rightOffset| because RTL position ditto. > Source/WebCore/platform/chromium/PopupMenuChromium.cpp:415 > +int PopupContainer::layoutAndRightOffset() The name layoutAndRightOffset() looks curious. Maybe layoutAndGetRightOffset() is better?
Created attachment 82293 [details] Patch
Comment on attachment 82293 [details] Patch Please review again.
Oops, just a moment. (In reply to comment #5) > (From update of attachment 82293 [details]) > Please review again.
Comment on attachment 82293 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82293&action=review > Source/WebCore/platform/chromium/PopupMenuChromium.cpp:351 > + // Use |popupInitialCoordinate.x()| + |rightOffset| because RTL position Please remove ||||.
Created attachment 82294 [details] Patch
Comment on attachment 82294 [details] Patch Deleted || notation. Please review.
Comment on attachment 82294 [details] Patch Clearing flags on attachment: 82294 Committed r78467: <http://trac.webkit.org/changeset/78467>
All reviewed patches have been landed. Closing bug.