Bug 54369 - Turn on -Woverloaded-virtual for GCC builds of JSC
Summary: Turn on -Woverloaded-virtual for GCC builds of JSC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Cameron Zwarich (cpst)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-13 16:08 PST by Cameron Zwarich (cpst)
Modified: 2011-02-13 16:22 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron Zwarich (cpst) 2011-02-13 16:08:11 PST 
Thanks to bug 53760, JSC builds with -Woverloaded-virtual using Clang. It should also build this way with GCC. If it does, we should enable the warning.
Comment 1 Cameron Zwarich (cpst) 2011-02-13 16:22:17 PST 
Actually, this warning is really broken in Apple's GCC. It requires derived classes to overload all base class signatures if they overload any of them.
Comment 2 Cameron Zwarich (cpst) 2011-02-13 16:22:37 PST 
I don't think we'll ever do this.