Bug 54354 – Web Inspector: [layout tests] get rid of elements-tests.js in favor of elements-tests2.js

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

New harness is way better for testing elements panel.

[Pavel Feldman]

Created attachment 82261 [details]
Patch

[Pavel Feldman]

This patch changes some expectations too:
- DOM trees are now expanded completely (not first 2 levels)
- Styles tests are re-using same dump facilities where possible
- elements-panel-limited-children is doing complete dumps

I did not touch inspector code, only tests were modified. Everything passes (and it took me a while to make it so, so there are no false positives).

Now we need to do the same to our console and timeline tests and inspector-test.js (old harness) can be deleted.

[Pavel Feldman]

Created attachment 82279 [details]
Patch

[Pavel Feldman]

Second patch is the same as the first + console tests are migrated to console-tests2.

Friendly note to the reviewer: All you need to do is to go through the modified expectations and see that only mechanical changes were performed.

[Yury Semikhatsky]

Comment on attachment 82279 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82279&action=review

> LayoutTests/http/tests/inspector/console-xhr-logging.html:45
> +        InspectorBackend.setMonitoringXHREnabled(false, callback);

Please restore enable/disable logging.

> LayoutTests/inspector/console-clear.html:18
> +

Please remove this line.

> LayoutTests/inspector/console-command-clear.html:36
> +    Tests that console is cleared upon clear() eval in console.

revert this change

> LayoutTests/inspector/elements-panel-selection-on-refresh.html:15
> + 

Please remove extra whitespace.

[Pavel Feldman]

Committed r78460: <http://trac.webkit.org/changeset/78460>