Bug 54354 - Web Inspector: [layout tests] get rid of elements-tests.js in favor of elements-tests2.js
Summary: Web Inspector: [layout tests] get rid of elements-tests.js in favor of elemen...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-13 05:42 PST by Pavel Feldman
Modified: 2011-02-14 02:59 PST (History)
10 users (show)

See Also:


Attachments
Patch (125.51 KB, patch)
2011-02-13 05:45 PST, Pavel Feldman
no flags Details | Formatted Diff | Diff
Patch (176.71 KB, patch)
2011-02-13 14:27 PST, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-02-13 05:42:17 PST
New harness is way better for testing elements panel.
Comment 1 Pavel Feldman 2011-02-13 05:45:49 PST
Created attachment 82261 [details]
Patch
Comment 2 Pavel Feldman 2011-02-13 05:48:53 PST
This patch changes some expectations too:
- DOM trees are now expanded completely (not first 2 levels)
- Styles tests are re-using same dump facilities where possible
- elements-panel-limited-children is doing complete dumps

I did not touch inspector code, only tests were modified. Everything passes (and it took me a while to make it so, so there are no false positives).

Now we need to do the same to our console and timeline tests and inspector-test.js (old harness) can be deleted.
Comment 3 Pavel Feldman 2011-02-13 14:27:47 PST
Created attachment 82279 [details]
Patch
Comment 4 Pavel Feldman 2011-02-13 14:31:32 PST
Second patch is the same as the first + console tests are migrated to console-tests2.

Friendly note to the reviewer: All you need to do is to go through the modified expectations and see that only mechanical changes were performed.
Comment 5 Yury Semikhatsky 2011-02-14 02:23:56 PST
Comment on attachment 82279 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82279&action=review

> LayoutTests/http/tests/inspector/console-xhr-logging.html:45
> +        InspectorBackend.setMonitoringXHREnabled(false, callback);

Please restore enable/disable logging.

> LayoutTests/inspector/console-clear.html:18
> +

Please remove this line.

> LayoutTests/inspector/console-command-clear.html:36
> +    Tests that console is cleared upon clear() eval in console.

revert this change

> LayoutTests/inspector/elements-panel-selection-on-refresh.html:15
> + 

Please remove extra whitespace.
Comment 6 Pavel Feldman 2011-02-14 02:59:33 PST
Committed r78460: <http://trac.webkit.org/changeset/78460>