Bug 54351 - Unnecessary call to containingBlock() in RenderBoxModelObject::relativePositionOffsetX()
Summary: Unnecessary call to containingBlock() in RenderBoxModelObject::relativePositi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-13 01:16 PST by Leo Yang
Modified: 2011-02-13 11:59 PST (History)
2 users (show)

See Also:


Attachments
Patch (2.50 KB, patch)
2011-02-13 01:31 PST, Leo Yang
no flags Details | Formatted Diff | Diff
Patch - fixed typo (2.50 KB, patch)
2011-02-13 04:10 PST, Leo Yang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Leo Yang 2011-02-13 01:16:50 PST
We don't need to call containningBlock() twice in RenderBoxModelObject::relativePositionOffsetX().
Comment 1 Leo Yang 2011-02-13 01:31:51 PST
Created attachment 82254 [details]
Patch
Comment 2 Andreas Kling 2011-02-13 03:51:15 PST
Comment on attachment 82254 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82254&action=review

r=me

> Source/WebCore/ChangeLog:5
> +        Unnecessary call of containningBlock() in RenderBoxModelObject::relativePositionOffsetX()

Typo, containingBlock()
Comment 3 Leo Yang 2011-02-13 04:10:23 PST
Created attachment 82257 [details]
Patch - fixed typo
Comment 4 WebKit Commit Bot 2011-02-13 11:31:54 PST
The commit-queue encountered the following flaky tests while processing attachment 82257 [details]:

animations/suspend-resume-animation.html bug 48161 (author: cmarrin@apple.com)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2011-02-13 11:33:33 PST
Comment on attachment 82257 [details]
Patch - fixed typo

Clearing flags on attachment: 82257

Committed r78437: <http://trac.webkit.org/changeset/78437>