Bug 54343 – Web Inspector: audits should not warn about gzip compression for 304s

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Alexander Romanovich]

It appears the audit tool is generating a red "Enable gzip compression" warning even if the resource in question was a "304 Not Modified" response with 0 content length. The gzip compression recommendation should be ignored in this case.

[Alexey Proskuryakov]

Maybe that's the reason for bug 33220?

[Alexander Romanovich]

Based on the patch for 33220, it appears not to be the reason. Which makes sense I guess. Audits are only run upon explicit user request, right?

[Alexander Pavlov (apavlov)]

Created attachment 82319 [details]
[PATCH] Suggested fix

[Alexander Pavlov (apavlov)]

(In reply to comment #2)
> Based on the patch for 33220, it appears not to be the reason. Which makes sense I guess. Audits are only run upon explicit user request, right?

Correct, it's a different thing.

[Yury Semikhatsky]

Comment on attachment 82319 [details]
[PATCH] Suggested fix

View in context: https://bugs.webkit.org/attachment.cgi?id=82319&action=review

> Source/WebCore/inspector/front-end/AuditRules.js:110
> +        var encodings = encodingHeader.split(/\s*,\s*/);

Consider replacing this code with a grep search.

> Source/WebCore/inspector/front-end/AuditRules.js:121
> +        return WebInspector.Resource.Type.isTextType(resource.type) && resource.domain && resource.statusCode !== 304 && resource.resourceSize !== undefined && resource.resourceSize > 150;

If 304s have 0 length content then we don't need to check for statusCode here. If resourceSize contains size of the whole response, we need to use another field which provides content length as only the content can be compressed.

[Alexander Pavlov (apavlov)]

Created attachment 83161 [details]
[PATCH] Comments addressed

[Alexander Pavlov (apavlov)]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       Source/WebCore/ChangeLog
        M       Source/WebCore/inspector/front-end/AuditRules.js
Committed r79229

[WebKit Review Bot]

http://trac.webkit.org/changeset/79229 might have broken Qt Linux Release
The following tests are not passing:
media/controls-without-preload.html